Skip to content

Report generated images as ACP locations#331

Open
tulsi-builder wants to merge 1 commit into
agentclientprotocol:mainfrom
tulsi-builder:tulsi/bot-823-image-artifact-locations
Open

Report generated images as ACP locations#331
tulsi-builder wants to merge 1 commit into
agentclientprotocol:mainfrom
tulsi-builder:tulsi/bot-823-image-artifact-locations

Conversation

@tulsi-builder

@tulsi-builder tulsi-builder commented Jul 22, 2026

Copy link
Copy Markdown

Summary

  • report a generated image’s canonical savedPath through ACP locations
  • use the same helper for normal completion and completed-only/history projection
  • terminalize replayed image generation items even when Codex persisted the historical generating status
  • omit locations when the saved path is absent or blank
  • cover completion, replay, missing/blank paths, matching image URI, and failed generations

Testing

  • npm test — 335 passed, 28 skipped
  • npm run typecheck
  • npm run build
  • live image generation: terminal tool_call_update contained image data, URI, and matching locations[0].path
  • replay of an existing image session: terminal tool_call contained image data, URI, and matching locations[0].path
  • git diff --check

This keeps rawOutput.savedPath diagnostic-only while allowing ACP clients to treat generated images as formal artifacts.

@tulsi-builder
tulsi-builder force-pushed the tulsi/bot-823-image-artifact-locations branch 2 times, most recently from f98a58b to 69cbbd4 Compare July 22, 2026 16:23
@tulsi-builder
tulsi-builder force-pushed the tulsi/bot-823-image-artifact-locations branch from 69cbbd4 to 5f9ee8e Compare July 22, 2026 16:27
@tulsi-builder

Copy link
Copy Markdown
Author

🤖 Maintainer note: the fork-origin CI workflow is currently awaiting approval (action_required). I ran the full local suite successfully (335 passed, 28 skipped), plus typecheck and build. I also validated both a fresh image generation and replay of an existing Codex image session; each emitted terminal status, inline image data/URI, and a matching ACP location.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant