Repository navigation
fix(ack-id): require DID URIs in controllerClaimSchema - #210
kutluhaneth46 wants to merge 1 commit into
Conversation
Validate controller credential subject id and controller as DID URIs in both Valibot and Zod so empty strings and non-DID values fail at the schema boundary. Fixes agentcommercekit#207
|
Warning Review limit reachedNext included review available in 59 minutes. View limit detailsLimit details: You’ve used all 2 included reviews currently available. You've used all free OSS reviews for now. Wait for the free limit to reset to keep reviewing this public repository. Review configuration: ⚙️ Run configurationConfiguration used: Organization UI Review profile: CHILL Plan: Team Run ID: 📒 Files selected for processing (4)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
|
@venables — |
|
Gentle bump — CI green / mergeable. Requires DID URIs in |
|
Gentle bump — still open and green on my side. Happy to rebase or adjust if anything is blocking review/merge. |
|
Friendly nudge — still open and mergeable. Happy to rebase or address review feedback anytime. |
|
Thanks for the time and for keeping the repo open to external contributions — much appreciated. Closing this PR to tidy up the queue: it's been open for a while with no maintainer review/feedback yet, and I don't want to leave stale noise around. Happy to reopen or submit a refreshed PR if useful. Thanks again! |
Summary
controllerClaimSchemaidandcontrollerto be DID URIs in both Valibot and Zod.createControllerCredentialtypes these fields.Testing
pnpm --filter @agentcommercekit/ack-id exec vitest run src/schemas/schemas.test.ts src/controller-claim-verifier.test.tsAI usage disclosure
Assisted by Cursor. I reviewed the controller claim verifier and credential creator types, implemented the dual-schema change, and ran the focused tests myself.
Fixes #207