fix(server): Omit null fields in control JSON editor#157
Merged
Conversation
Codecov Report✅ All modified and coverable lines are covered by tests. 📢 Thoughts on this report? Let us know! |
namrataghadi-galileo
approved these changes
Apr 1, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
This updates the control JSON editor so
nullobject fields are not rendered in Full JSON mode.What changed
nullWhy
Controls are not persisted with these
nullkeys in the database, but the UI was rendering the nullable transport shape returned by the API. That made Full JSON mode noisy with entries like"or": nulland"selector": null.Validation
pnpm exec eslint src/core/page-components/agent-detail/modals/edit-control/edit-control-content.tsx src/core/page-components/agent-detail/modals/edit-control/utils.ts tests/agent-detail.spec.tsNotes
motion/reactmodule when starting a fresh dev server.make ui-typecheckalso currently fails elsewhere in the UI for unrelated type errors.