feat(site): consolidate UX review into shared design-system foundations - #30
Merged
OriNachum merged 38 commits intoAug 7, 2026
Merged
Conversation
An outside UX review contributed as docs/ux-review/. Additive only: no file under site-astro/ is modified. Reviewed against a local production build at d71a719. Seven findings, each with its measurement and a re-run recipe: - /agents/ renders 30 cards in one visual language leading to three kinds of destination (4 in-site pages, 25 GitHub, 1 other host) with no signal which - the clickable region on those cards is 4% of the card; the home page already solves this with a whole-card anchor - the intro copy ("Every entry links to its public repository") is now false for 5 of 30 entries - 30 entries across 6 groups with no jump list, anchors or counts - /learn/ sits first in the primary nav and 404s until cutover - the four agent pages are structural clones; ReachyTerminal is ColleagueTerminal with every class r-prefixed, against Astro's automatic style scoping - 92 outbound links carry no off-site affordance Also records what was checked and found correct — contrast (AA in both themes, lowest 6.37:1), heading order on all 8 routes, scrollable-table role/tabindex/aria-label, mobile layout at 360px, and the reduced-motion and no-JS handling. Those sections mark what a fix could regress. Artefacts are self-contained HTML and markdown so they can be read by agents or opened in a browser without a build step. Each copies the site's own tokens verbatim; none introduces a colour, font or radius the site does not already define. Note for review: no version bump is included. The version-check job fails any PR whose pyproject.toml version matches main's, so run the version-bump skill before opening this.
findings.md described captures-layout.html as "Three layouts"; it now carries four (masonry, capped-scroll, single-column, expand-in-place), with expand-in-place as the recommendation. Co-Authored-By: Claude Opus 4.8 <noreply@anthropic.com>
DigitalBoopLtd
marked this pull request as ready for review
July 26, 2026 18:19
PR Summary by Qodofeat(site): consolidate UX review into shared design-system foundations
AI Description
Diagram
High-Level Assessment
Files changed (56)
|
Code Review by Qodo
1.
|
![qodo-code-review[bot]](https://avatars.githubusercontent.com/in/484649?s=60&v=4){kind=small}
Contributor
|
Huge thank you! You didn't add credit and link to your works - I will add it on another PR. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
section introductions, destination cards, structured cards, closing bands,
inline code, and terminal treatments.
those shared patterns while preserving their bespoke compositions.
accessible transcript evidence, read-only human-gate previews, and a quieter
seven-stage pipeline reference.
review pages, static snapshots, fonts, and superseded decision notes are not
part of the final diff.
Why
The review identified repeated page-level implementations and inconsistent
layout, wayfinding, destination, card, and terminal treatments. This PR turns
the accepted findings into shared source patterns with focused regression
coverage, while keeping page-specific diagrams, content, and presentation
layouts local.
The final review record is the
site-ux-review delivery summary.
Scope and impact
directory, Library destinations, and internal/external destination cues.
build and the existing presentation and slide-data validation.
data still fails the Astro build; dated component inventories remain delivery
evidence rather than permanent CI gates.
AgentPage/Terminalabstractions, Learn source/deployment, and automatic future-page adoption out
of scope.
0.18.2to0.19.0.Validation
black,isort,flake8, andbanditpassed.markdownlint-cli2@0.21.0passed across 60 Markdown files.git diff --checkpassed;site-astro/package.jsonmatchesmain.Review notes
The final PR comparison contains 56 files and 5,712 additions, down from 83
files and 17,030 additions. Documentation is limited to nine formal records
(546 lines); no
docs/ux-review/path, generated mock asset, or migration-onlycheck script remains.
Manual visual and keyboard review can continue on this draft PR and its deploy
preview before it is marked ready for review.