Repository navigation
test(agent): lock the execution binding of the successful model turn (issue #269) - #343
Merged
yuluo-yx merged 1 commit intoNov 1, 2026
Conversation
yuluo-yx
approved these changes
Nov 1, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Describe what this PR does / why we need it
Locks the acceptance behavior of #269 with the test suite the issue requires. With #333 merged, the main scenario is already covered: an interceptor that swaps the whole registry via
ModelRequest.toolRegistry(...)now has its registry flow into the effective tool set and back to the same-turn execution, so the issue's repro (original=1, replacement=0) no longer reproduces on current main — but none of the six behavior scenarios the issue's acceptance criteria ask for existed as tests, and the fallback/multi-attempt binding semantics were unproven.Does this pull request fix one issue?
Fixes #269
Describe how you did it
Five new offline cases in
ReActAgentTest(existing ScriptedClient pattern, one with a scripted-stream subclass):No production code was needed: the effective-set handoff introduced in #333 (chain-end resolution, per-turn
AtomicReference, success-turn ownership) already satisfies the issue's acceptance criteria; this PR turns that into locked, reviewable behavior.Describe how to verify it
./mvnw -pl argi-agent/argi-agent-core -am test -DskipTests=false -Dtest=ReActAgentTest— 21/21 green (16 pre-existing + 5 new). Full argi-agent-core reactor: 132/132. Checkstyle clean.Special notes for reviews
The issue's duplicate-name clause (static shadows dynamic on conflicts) was already settled by #333's
resolveTools/effectiveToolSetmerge and is exercised bystaticToolShadowsDynamicToolOnNameConflict. If the maintainers would rather close #269 as covered-by-#333 without this test PR, I'm happy to — but the acceptance criteria explicitly call for these behavior tests, so submitting them as the issue's deliverable.