Repository navigation
test: find the SwagCommercial clone via MQ_COMMERCIAL_CLONE - #236
Merged
Merged
Conversation
…rdcoded home path ReleaseCapabilityMatrixTest pointed at one developer's absolute home directory, which leaked a personal path into the public repository and made the guard skip for everyone else. It now reads MQ_COMMERCIAL_CLONE and falls back to $HOME/projects/swagcommercial, the same shape CoreFloorCompatibilityTest uses for MQ_CORE_CLONE. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
ReleaseCapabilityMatrixTesthardcodedCLONE_PATHas an absolute path under one developer's home directory. That leaked a personal path into this public repo and made the guard skip on every other machine.It now follows the
CoreFloorCompatibilityTestpattern:MQ_COMMERCIAL_CLONE$HOME/projects/swagcommercialNo SwagCommercial clone at <path>; set MQ_COMMERCIAL_CLONE to run this guard.docs/development.mdnow names the default location and the env var, matching theMQ_CORE_CLONEsentence beside it.Test plan
MQ_COMMERCIAL_CLONE=<clone>: passesMQ_COMMERCIAL_CLONE=/nonexistent: all 6 skip with the message abovecomposer run quality: exit 0composer run test: 1923 tests OKgit grep "/Users/": no other hits in tracked files🤖 Generated with Claude Code