In-agent UX hook side: quiet turns, session receipt, /acp-approve, approval-landed context (0.28.0) - #48
Draft
davidcrowe wants to merge 1 commit into
Draft
In-agent UX hook side: quiet turns, session receipt, /acp-approve, approval-landed context (0.28.0)#48davidcrowe wants to merge 1 commit into
davidcrowe wants to merge 1 commit into
Conversation
…notices - Stop now prints a per-turn line only when the turn held a call, flagged, or got a shadow/cost notice, plus a reminder for still-pending approvals; cumulative counters move to SessionEnd (new event) and no longer clear on every Stop, so a multi-turn session's receipt isn't just the last turn. - UserPromptSubmit polls GET /plugin/intents/approvals (<=1.5s, silent on failure) for this session's pending held calls and surfaces newly approved ones as a model-facing retry line (additionalContext on Claude Code, systemMessage fallback on Codex/Copilot); skipped entirely for subagents and when nothing is pending. - New /acp-approve command (UserPromptExpansion) lists or filters this session's pending held calls from local state, same pattern as /acp-status. - agent_notice on PostToolUse now reaches the model via additionalContext on Claude Code, with a systemMessage fallback on harnesses that only honor additionalContext at SessionStart. - SessionStart surfaces catch_up and upgrade_notice (capped once per 24h) as human-facing systemMessage; upgrade_notice supersedes the older model-facing notice field per contract instead of double-emitting it. - UNGOVERNED banner during a gateway outage now fires once at the start of the outage and once more (with a call count) on recovery, instead of repeating on every call in between. - Bump plugin version to 0.28.0; wire SessionEnd and UserPromptSubmit into hooks.json. Tests: three new files (turn-and-session-receipt, approvals-and-notices, notices-and-outage) covering the above; full suite passes (305 tests).
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Hook side of davidcrowe/gatewaystack-connect#1346–#1352 (0.28.0). Do not merge or publish yet: dogfooding locally via
--plugin-diragainst the internal-onlyin_agent_uxrollout; review after a few days of live data./acp-approve [code]: this session's held calls with code, age and a workspace-pinned link. Approves nothing.agent_noticereaches the model;noticestays human-facing.catch_upandupgrade_noticeto the human; upgrade at most once per 24h, and the old model-facing upgrade text is dropped when the new one is present.Tests: 305/305.
retry-before-fail-closed.test.mjsreports a file-level timeout on origin/main too.