Repository navigation
Show gateway notices after each tool + shared conformance suite (0.3.1) - #13
Merged
Merged
Conversation
…1334) The post hook posted to /govern/tool-output and ignored the reply's notice, so every cost advisory was silent in Hermes. Hermes has no message channel on the post hook, so the notice goes to stderr, the surface this plugin already uses for the person. ACP_SHADOW=off silences it, matching the Claude Code plugin. No version bump yet: bump on merge, after Fable review.
Vendors the byte-identical shared plugin-corpus.json and adds tests/test_conformance.py, which drives the real post_tool_call hook against a fake gateway and checks the notice and post-tool capability contracts. Records the known #1334 notice-drop divergence in EXPECTED_DIVERGENCES so a fix turns CI red until the entry is removed. Also adds a minimal GitHub Actions workflow running the full pytest suite including the new adapter.
… folder name The guard hard-coded 'hermes-acp-plugin-conf', so it failed in any other checkout, including the CI clone the new workflow runs in.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What this changes
_post_tool_call()insrc/acp_hermes/__init__.pynow readsnoticefrom the/govern/tool-outputreply and writes it to stderr after each tool. Before this change the reply was thrown away.ACP_SHADOW=offsilences it, which matches the Claude Code plugin. New tests are intests/test_hooks.py.tests/test_conformance.pyand the vendored corpustests/fixtures/plugin-corpus.json(hashaa186d3fb3e7d18c). A guard checks thatacp_hermesis imported from this repo's ownsrc/. It compares paths rather than folder names, so it holds in a CI clone.EXPECTED_DIVERGENCESis now empty. Thenotice-shown(#1334) entry is removed because the fix makes it pass..github/workflows/test.yml.pyproject.tomland_FALLBACK_VERSION). Nothing is published to PyPI.Tests
Local run of
PYTHONPATH=src .venv/bin/pytest -q testson this branch: 59 passed. That includes the notice tests and the adapter with no divergences. Main is at 57.This is the new workflow's first real run.
Ships under ship-when-confident; Fable reviews after (queue +G/+I).
Refs davidcrowe/gatewaystack-connect#1344, davidcrowe/gatewaystack-connect#1334