Shared plugin conformance suite (gatewaystack-connect#1344 step 1) - #3
Open
davidcrowe wants to merge 1 commit into
Open
davidcrowe wants to merge 1 commit into
davidcrowe wants to merge 1 commit into
Conversation
Vendors the shared plugin-corpus fixture and adds an adapter test that pins its fingerprint, confirms the notice and post-tool capabilities are recorded not-possible for this plugin (OpenClaw has no after-tool hook), and asserts register() only wires up before_tool_call so a future after-tool hook addition fails the check instead of going unnoticed. Also adds a minimal GitHub Actions workflow since none existed for this public repo.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What this changes
This adds the shared L1 plugin conformance adapter and the vendored corpus
test/fixtures/plugin-corpus.json(hashaa186d3fb3e7d18c) for gatewaystack-connect#1344 step 1. The adapter runs the canonical notice and post-tool cases against this plugin's real entry point, using a fake gateway.EXPECTED_DIVERGENCESlists anything that still fails, and a test checks the list is exact, so a new failure or a silent fix both turn CI red.The branch is rebased onto the current
origin/main. Only tests are added; plugin code is not changed.Tests
Local run on this branch: npm test (build + node --test): 37/37 pass.
Adds
.github/workflows/test.yml. This is the workflow's first real run.Ships under ship-when-confident; Fable reviews after (queue +G/+I).
Refs davidcrowe/gatewaystack-connect#1344