Fix MPP fetch#13
Merged
Merged
Conversation
There was a problem hiding this comment.
cubic analysis
No issues found across 4 files
Linked issue analysis
Linked issue: ENG-300: SDKs x402/MPP
| Status | Acceptance criteria | Notes |
|---|---|---|
| ✅ | probe402 accepts an optional fetch function and uses it | Added fetchFn param and used fetchFn(httpUrl) in util.ts |
| ✅ | getPaymentCredentials passes mppx.rawFetch to probe402 | getPaymentCredentials now calls probe402(wsUrl, mppx.rawFetch) |
| ✅ | MppxClient interface includes a rawFetch property | Raw fetch added to MppxClient interface in mppx.ts |
| ✅ | Avoid using signed requests for the initial 402 probe (use client's raw fetch) | probe402 now accepts injected fetch and getPaymentCredentials passes rawFetch |
| ✅ | Unit tests updated to mock rawFetch where applicable | Tests were modified to include rawFetch mocks in two test files |
| Enable correct credential creation (response used to create credentials) | Response passed to createCredential but no test verifies credential correctness |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary by cubic
Fixes MPP/x402 fetch by using the client's raw fetch for the initial 402 probe, avoiding signed requests and enabling correct credential creation. Aligns with ENG-300 (SDKs x402/MPP).
probe402now accepts an optionalfetchFnand uses it.getPaymentCredentialspassesmppx.rawFetchtoprobe402.rawFetch.Written for commit 3e77ef9. Summary will update on new commits.