Skip to content

fix: prevent adapter option collisions from bricking the CLI - #529

Merged
ankitranjan7 merged 2 commits into
agentrhq:mainfrom
jaysaadana5:fix/adapter-shared-option-collisions
Sep 25, 2026
Merged

ankitranjan7 merged 2 commits into
agentrhq:mainfrom
jaysaadana5:fix/adapter-shared-option-collisions

Conversation

@jaysaadana5

Copy link
Copy Markdown
Collaborator

Summary\n- skip webcmd shared execution flags when an adapter owns the same long option\n- keep adapter-owned colliding options out of output-format and runtime-global handling\n- cover collisions across output, tracing, verbose, and browser execution flags\n\nFixes #441\n\n## Verification\n- npm run typecheck\n- npm test -- src/command-surface.test.ts\n- npm test

@github-actions

github-actions Bot commented Sep 17, 2026 •

Copy link
Copy Markdown
Contributor

🟠 Maintainer review suggested — low confidence

The automated review could not reach a fully supported conclusion.

Limitations

  • Some automated findings could not be verified against the pull request diff.

This review is advisory and does not block merging.

@ankitranjan7
ankitranjan7 merged commit 4713d01 into agentrhq:main Sep 25, 2026
15 checks passed
@ankitranjan7

Copy link
Copy Markdown
Contributor

Thanks for the fix and the regression tests — merged!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants