Repository navigation
fix: copy sibling plugin files when creating an adapter override - #533
Merged
ankitranjan7 merged 2 commits intoSep 25, 2026
Merged
ankitranjan7 merged 2 commits into
ankitranjan7 merged 2 commits into
Conversation
createAdapterOverride() only copied the named command file into ~/.webcmd/clis/<site>/, so a plugin command that imports a sibling file in the same plugin directory (shared helpers, types, constants) would have that import resolve to nothing once forked. Copy every other file in the plugin's directory alongside the command file, skipping any that already exist in the override directory so a user's own edits to a sibling aren't clobbered. Fixes agentrhq#418
Contributor
🟢 No documentation gap found — medium confidenceThe automated review found no documentation gap in the supplied changes. This review is advisory and does not block merging. |
Contributor
|
Thanks for the fix and the regression tests — merged! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
createAdapterOverride()only copied the named command file into~/.webcmd/clis/<site>/, so a plugin command that imports a sibling file in the same plugin directory (shared helpers, types, constants) would have that import resolve to nothing once forked.Fix: copy every other file in the plugin's directory alongside the command file when creating an override, skipping any that already exist in the override directory so a user's own edits to a sibling aren't clobbered.
Related issue: Fixes #418
Type of Change
Checklist
skill-src/, I ranmake buildand committedskills/(N/A)Adapter Notes
CliErrorsubclasses instead of rawError(N/A)Screenshots / Output
node_modules\.bin\tsc --noEmit— cleannode_modules\.bin\vitest run src/adapter-override.test.ts:2 new tests: sibling files are copied; an existing sibling override isn't overwritten.