Repository navigation
Conversation
A template expression that starts and ends with a string literal, such as
${{ 'https://x.test/' + item.id + '/' }}, matched the quoted-literal fast
path and rendered its own source text instead of being evaluated. A | inside
a quoted string, as in join(' | ') or 'a|b', was treated as a filter
separator, so the filter was silently skipped or the literal became undefined.
Limit the fast path to literals whose body has no delimiter or backslash,
and split filters with a quote-aware scanner that falls back to the plain
split when a quote is unterminated.
Contributor
🟠 Maintainer review suggested — low confidenceThe automated review could not reach a fully supported conclusion. Limitations
This review is advisory and does not block merging. |
adikulkarni006
approved these changes
Oct 5, 2026
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Pipeline template expressions (
${{ ... }}) are parsed without regard to quotes, so two ordinary shapes render wrongly. There is no tracking issue; the repro is below.${{ 'https://x.test/' + item.id + '/' }}https://x.test/' + item.id + '/(its own source text)https://x.test/7/${{ 'x' === 'x' ? 'yes' : 'no' }}yes${{ item.tags | join(' | ') }}a | b | c${{ 'a|b' }}undefineda|bTwo causes in
src/pipeline/template.ts:/^(['"])(.*)\1$/), so a concatenation or ternary wrapped in string literals was returned as text instead of being evaluated.|, including one inside a quoted string.Changes
'it\'s'are now evaluated properly.default(it's)), the quotes are not string delimiters, so it falls back to the previous split and behaviour is unchanged.Type of Change
Verification
src/pipeline/template.test.ts; 5 fail onmain, the other 2 pin behaviour that already workednpx vitest run --project unit src/pipeline(108 pass)npm run typecheck