Skip to content

refactor: use manifest.apiVersion in validate output instead of hardcoded literal #56

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
AyoubHolmes wants to merge 1 commit into
base: main
Choose a base branch
from
Open

refactor: use manifest.apiVersion in validate output instead of hardcoded literal #56

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
9 changes: 9 additions & 0 deletions packages/cli/src/__tests__/cli.test.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -51,6 +51,15 @@ describe('agentspec validate', () => {
const json = JSON.parse(result.stdout)
expect(json.valid).toBe(false)
})

it('human-readable output reflects the manifest apiVersion (not a hardcoded literal)', async () => {
const result = await runCli(['validate', exampleManifest])
expect(result.exitCode).toBe(0)
expect(result.stdout).toContain('agentspec.io/v1')
const jsonResult = await runCli(['validate', exampleManifest, '--json'])
const json = JSON.parse(jsonResult.stdout)
expect(json.apiVersion).toBe('agentspec.io/v1')
})
})

describe('agentspec audit', () => {
Expand Down
2 changes: 1 addition & 1 deletion packages/cli/src/commands/validate.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -30,7 +30,7 @@ export function registerValidateCommand(program: Command): void {

printHeader('AgentSpec Validate')
printSuccess(
`Manifest valid — ${chalk.cyan(manifest.metadata.name)} v${manifest.metadata.version} (agentspec.io/v1)`,
`Manifest valid — ${chalk.cyan(manifest.metadata.name)} v${manifest.metadata.version} (${manifest.apiVersion})`,
)
console.log(chalk.gray(` Provider : ${manifest.spec.model.provider}/${manifest.spec.model.id}`))
console.log(chalk.gray(` Tools : ${manifest.spec.tools?.length ?? 0}`))
Expand Down