fix: make dimensions parameter optional in OpenAITextEmbedding (#1095)#1110
Open
egezturkk wants to merge 3 commits intoagentscope-ai:mainfrom
Open
fix: make dimensions parameter optional in OpenAITextEmbedding (#1095)#1110egezturkk wants to merge 3 commits intoagentscope-ai:mainfrom
egezturkk wants to merge 3 commits intoagentscope-ai:mainfrom
Conversation
Codecov Report❌ Patch coverage is
📢 Thoughts on this report? Let us know! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
AgentScope-Java Version
1.0.12-SNAPSHOT
Description
Background & Purpose:
Currently,
OpenAITextEmbeddingenforces a mandatorydimensionsparameter. This causes 400 Bad Request errors when using open-source embedding models (like BAAI/bge) through the OpenAI-compatible API, as these models do not support the Matryoshka representation parameter.Changes:
dimensionstype frominttoIntegerinOpenAITextEmbeddingand itsBuilder.1536to make it optional.dimensionsfield in the API payload if it is explicitly provided.embed(),getDimensions(), and validation logic to ensure stability.How to test:
Initialize
OpenAITextEmbeddingwithout calling.dimensions(). Verify that the outgoing JSON request to the embedding endpoint does not contain thedimensionskey.Checklist