refactor(hook): change PreCallEvent related comments from read-only to modifiable, aligning with PreReasoningEvent#1155
Open
jujn wants to merge 2 commits intoagentscope-ai:mainfrom
Open
Conversation
…o modifiable, aligning with PreReasoningEvent
Contributor
There was a problem hiding this comment.
Pull request overview
This PR updates hook documentation and behavior so PreCallEvent is treated as a modifiable hook event (similar to PreReasoningEvent), allowing hooks to alter the input message list before the agent processes it.
Changes:
- Mark
PreCallEventas modifiable and documentgetInputMessages/setInputMessages. - Copy
inputMessagesonPreCallEventconstruction and enforce non-null inputs. - Update
HookJavadoc to listPreCallEventamong modifiable events (and remove it from notification-only events).
Reviewed changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated 2 comments.
| File | Description |
|---|---|
| agentscope-core/src/main/java/io/agentscope/core/hook/PreCallEvent.java | Makes PreCallEvent input messages modifiable and aligns list handling with other modifiable events. |
| agentscope-core/src/main/java/io/agentscope/core/hook/Hook.java | Updates hook documentation to categorize PreCallEvent as a modifiable event. |
agentscope-core/src/main/java/io/agentscope/core/hook/PreCallEvent.java
Outdated
Show resolved
Hide resolved
agentscope-core/src/main/java/io/agentscope/core/hook/PreCallEvent.java
Outdated
Show resolved
Hide resolved
Codecov Report✅ All modified and coverable lines are covered by tests. 📢 Thoughts on this report? Let us know! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
This PR updates PreCallEvent to be modifiable (revising the previous read-only comments), and aligns its inputMessages handling with PreReasoningEvent.
Checklist
Please check the following items before code is ready to be reviewed.
mvn spotless:applymvn test)