fix(tool): support Flux-returning tool methods#1171
Open
Alexxigang wants to merge 1 commit intoagentscope-ai:mainfrom
Open
fix(tool): support Flux-returning tool methods#1171Alexxigang wants to merge 1 commit intoagentscope-ai:mainfrom
Alexxigang wants to merge 1 commit intoagentscope-ai:mainfrom
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Why this fix
Issue #938 happens because invokeAsync(...) only special-cases CompletableFuture and Mono. When a tool method returns Flux<?>, the current code falls through the synchronous branch, serializes the Flux object itself, and never subscribes to the stream. That means the parent agent never waits for or consumes the streamed tool output.
This change subscribes to Flux results, forwards intermediate chunks to hooks, and converts the aggregated stream output into the final ToolResultBlock returned to the LLM-facing caller.
Validation
AI Assistance