fix(update): parse versions endpoint as keyed object, not array - #17
Open
dribblejerp-KlunkDunker wants to merge 1 commit into
Open
Conversation
GET /agent/skills/version returns an object keyed by slug ({"versions":
{slug: {contentSha}}}), but updateCommand typed it as VersionEntry[] and
called .map() on it, so every `ags update` crashed with
"remote.map is not a function" as soon as any skill was installed.
Parse the keyed object instead; the resolved map is unchanged.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
ags updatecrashes withTypeError: remote.map is not a functionas soon as any skill is installed and tracked in the lock file.updateCommandtypes theGET /agent/skills/versionresponse as an array and calls.map()on it, but the API returns an object keyed by slug ({"versions": {slug: {contentSha}}}), so everyags update(interactive and--json) is a hard crash.Reproduction
Expected: "All N skills up to date" (or an update prompt).
Actual:
Root cause
The endpoint returns a keyed object:
remoteis{ versions: {...} }— an object, which has no.map(). TheVersionEntry[]type hides the mismatch from the compiler.Fix
Parse the keyed object instead of assuming an array; the resolved map is unchanged.
Verification
tsc --noEmitpasses with the change.ags update --json→{"updated":[],"upToDate":2}with the resolved map matching both lock-tracked skills'contentShas exactly.Suggested follow-ups for maintainers
apiFetchresults (e.g.list,find).apiFetchvalidate the response shape so a mismatch throws a descriptive error instead of a rawTypeErrordeep in a command.