Skip to content

Quality: SingleResult dataclass fields default to None but typed as non-Optional — will crash on attribute access #288

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
kumburovicbranko682-boop wants to merge 1 commit into
base: main
Choose a base branch
from
Open

Quality: SingleResult dataclass fields default to None but typed as non-Optional — will crash on attribute access #288

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 3 additions & 2 deletions sdk/python/validation/models.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -4,6 +4,7 @@

from dataclasses import dataclass
from pathlib import Path
from typing import Optional


@dataclass
Expand Down Expand Up @@ -35,5 +36,5 @@ class RunResult:
class SingleResult:
"""Result of running one example with one model (single-run mode)."""

example: Example = None # type: ignore[assignment]
result: RunResult = None # type: ignore[assignment]
example: Optional[Example] = None
result: Optional[RunResult] = None
Loading