Add a conda env as option for readers#506
Merged
ageron merged 2 commits intoageron:masterfrom Oct 28, 2019
Merged
Conversation
Contributor
Author
|
Moreover, the problem mentioned by you in #369 can be solved if you have an |
Owner
|
Hi @volpatto , |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Hi, @ageron!
First of all, congratulations for your great book!
I'm trying here to do a very small contributions in this PR, aiming for
condausers (just like me). I'm adding anenvironment.ymlwith the same setup asrequirements.txt. So, the user now can generate the same environment both forvirtualenv(with therequirements.txt) andconda(with the new file).To do so, one can just run:
$ conda env create -f environment.ymlAn advantage with this contribution is the enhanced reproducibility. Also, it is easier for the user, since the user doesn't need to care about packages and versions (everything is already configured) A drawback is that when you update
requirements.txt, you have to updateenvironment.ymlas well, to match packages' versions. Put it simply, both files have to be maintained.I updated README with instructions. Please, do a double check there!
Thanks and I hope that you appreciate this PR!