This makes it easier for people to install with the PHP package manager, composer#19
Open
bradchesney79 wants to merge 13 commits intoagilecrm:masterfrom
Open
This makes it easier for people to install with the PHP package manager, composer#19bradchesney79 wants to merge 13 commits intoagilecrm:masterfrom
bradchesney79 wants to merge 13 commits intoagilecrm:masterfrom
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Three things:
Changed from the marginally more resource consuming doublequoted strings to singlequoted strings
Added looking for settings from a dotenv .env file
Added a composer.json file
I've tagged this commit as v3.1.0 in my fork...
Look over the composer.json carefully -- your use case probably is fit best by the MIT license, maybe not. Your call.
But, it is a good solid start on helping out people using the wildly popular composer PHP package manager. Also, if you ever wanted to publish the repo to the packagist-- which is the PHP paralell of the nodejs npmjs or the python cheesefactory/warehouse.