Skip to content

ci: skip duplicate feature flag gate #10

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
kazukinakai merged 1 commit into from
Jul 24, 2026
Merged

ci: skip duplicate feature flag gate #10

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions .github/workflows/quality-gate.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -164,7 +164,7 @@ jobs:
feature-flag-check:
name: feature-flag-check
needs: detect
if: ${{ needs.detect.outputs.heavy == 'true' }}
if: ${{ needs.detect.outputs.heavy == 'true' && needs.detect.outputs.native_required != 'true' }}
uses: ./.github/workflows/feature-flag-check.yml
with:
runs-on: ${{ inputs.linux-runs-on }}
Expand Down Expand Up @@ -283,6 +283,6 @@ jobs:
"rust-ci": ${{ needs.detect.outputs.rust == 'true' && needs.detect.outputs.heavy == 'true' }},
"swift-ci": ${{ needs.detect.outputs.swift == 'true' && needs.detect.outputs.heavy == 'true' && needs.detect.outputs.native_required != 'true' && !github.event.repository.private }},
"secret-scan": ${{ needs.detect.outputs.native_required != 'true' }},
"feature-flag-check": ${{ needs.detect.outputs.heavy == 'true' }},
"feature-flag-check": ${{ needs.detect.outputs.heavy == 'true' && needs.detect.outputs.native_required != 'true' }},
"repository-gates": ${{ needs.detect.outputs.required_contexts != '[]' }}}
run: node .quality-gate-source/.github/scripts/evaluate_quality_gate.mjs
7 changes: 7 additions & 0 deletions tests/test_workflow_wiring.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -86,6 +86,13 @@ def test_native_gate_repositories_do_not_run_duplicate_language_or_secret_gates(
self.assertIn("native_required: ${{ steps.native.outputs.required_contexts != '[]' }}", source)
self.assertGreaterEqual(source.count("needs.detect.outputs.native_required != 'true'"), 6)

def test_native_gate_repositories_do_not_run_duplicate_feature_flag_gate(self) -> None:
source = QUALITY_GATE.read_text()
self.assertIn(
"needs.detect.outputs.heavy == 'true' && needs.detect.outputs.native_required != 'true'",
source,
)

def test_secret_scan_is_required_only_when_selected(self) -> None:
evaluator = (ROOT / ".github/scripts/evaluate_quality_gate.mjs").read_text()
self.assertIn("const required = new Set();", evaluator)
Expand Down