カスタムフィールド設定画面:トラッカー選択の表示改善#9
Draft
telegib wants to merge 25 commits into
Draft
Conversation
* add postgres 10.21, 11.16, 12.11, 13.7, 14.3 * use versions existing on hub.docker.com (10.20, 11.15, 12.10, 13.6, 14.2) * Upgrade ci postgres version from 9.5 to 10 (drop 10.20, 11.15, 12.10, 13.6, 14.2) Co-authored-by: Ko Nagase <nagase@georepublic.co.jp>
* Add VSCode devcontainer用の設定を追加 * Add docker-compose.yml * Move Dockerfile-for-redmine-dev-mirror to .devcontainer/Dockerfile * Fix Rubyのバージョン変更の手順 * Update README.md * Update DockerfileでADDしなくなったことによって機能しなくなっていたコードを削除
* Adjust docker-compose.yml MySQL settings and expose PostgreSQL/MySQL ports * Adjust SQLTools MySQL driver and connections
nishidayuya
approved these changes
Jun 30, 2023
nishidayuya
left a comment
nishidayuya
left a comment
There was a problem hiding this comment.
LGTMです! 🎉 対応おつかれさまでした．
気づいた点は細かいことですのでApproveします．
| @@ -1,11 +1,12 @@ | |||
| <fieldset class="box" id="custom_field_tracker_ids"><legend><%= toggle_checkboxes_link("#custom_field_tracker_ids input[type=checkbox]") %><%=l(:label_tracker_plural)%></legend> | |||
|
|
|||
There was a problem hiding this comment.
細かいですが，余分な空行がありそうです．
Suggested change
Author
There was a problem hiding this comment.
ご指摘ありがとうございます！見落としていました、、、ので、commit を追加しました。
kumojima
approved these changes
Jun 30, 2023
|
Patch can be downloaded here |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
9 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
redmine.orgのチケットURL(feature): https://www.redmine.org/issues/38650
（patch のものはまだ未作成）
改善内容
→ プロジェクト設定画面のトラッカー選択タブのように整列させて見やすくしたい。
修正点
イメージ
修正前
修正後