etl command feedback from data team - #20
Merged
Merged
Conversation
Contributor
There was a problem hiding this comment.
Pull request overview
Updates the UTRANS CLI ETL mapping behavior to better preserve unmapped domain values (and capture them in notes), and adds repo-local CLI development/validation instructions for contributors working under cli/**.
Changes:
- When a source value can’t be resolved to a coded-value domain, the mapper now copies the raw/transformed value into the target field and appends a note.
- Truncates
UTRANS_NOTESto 200 characters when appending mapping notes. - Adds
.github/instructions/cli.instructions.mdwith Conda environment activation guidance for CLI work.
Reviewed changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated 1 comment.
| File | Description |
|---|---|
| cli/src/utrans/etl_mappers.py | Adjusts mapping fallback behavior and note truncation when domain resolution fails. |
| .github/instructions/cli.instructions.md | Adds CLI-specific development/validation instructions (Conda env activation). |
💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.
acneville
approved these changes
Aug 20, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.