Address add-in feedback - #23
Merged
Merged
Conversation
There was a problem hiding this comment.
Pull request overview
This PR updates the ArcGIS Pro add-in editor workflow based on feedback by adding explicit support for creating UTRANS roads from unlinked “New” DFC_RESULT records (including multi-select), expanding editable road attributes (STATUS), and streamlining release packaging/versioning.
Changes:
- Add an Add New workflow to create and link UTRANS roads for eligible unlinked “New” DFC records (including multi-select) with configurable attribute overrides.
- Extend editor/UI to support editing the STATUS coded-value field and improve editor state handling for “new/unlinked” selections.
- Add Release build automation (version bump + package copy) and improve developer documentation / VS Code configuration.
Reviewed changes
Copilot reviewed 14 out of 14 changed files in this pull request and generated 8 comments.
Show a summary per file
| File | Description |
|---|---|
| add-in/UGRC.UtransTools/UtransEditorDockpaneViewModel.cs | Adds Add New command/state tracking for multi-select new records; updates save/reset behavior. |
| add-in/UGRC.UtransTools/UtransEditorDockpaneView.xaml | Updates editor UI to enable Add New workflow, adds STATUS control, and adjusts enabled/visible behaviors. |
| add-in/UGRC.UtransTools/UGRC.UtransTools.csproj | Adds Release build targets for version bumping and copying the packaged add-in. |
| add-in/UGRC.UtransTools/Services/UtransEditService.cs | Implements creation/linking of new UTRANS roads and adds STATUS to edit payloads. |
| add-in/UGRC.UtransTools/Services/LayerValidationService.cs | Improves layer validation (broken sources) and includes STATUS coded domain loading. |
| add-in/UGRC.UtransTools/Services/DfcSelectionService.cs | Adds multi-select loading for eligible new/unlinked DFC_RESULT records. |
| add-in/UGRC.UtransTools/Models/EditorReviewState.cs | Adds STATUS field to review state and adjusts defaults/initialization for new records. |
| add-in/UGRC.UtransTools/Models/AttributeReviewField.cs | Fixes IsDifferent to reflect current edited value and updates change notifications. |
| add-in/UGRC.UtransTools/Configuration/UtransEditorConfiguration.cs | Adds STATUS to the set of common road fields. |
| add-in/UGRC.UtransTools/Config.daml | Updates add-in version (and normalizes the XML header formatting). |
| add-in/UGRC.UtransTools/Build/BumpAddInVersion.ps1 | New script to bump the add-in version during Release builds. |
| add-in/README.md | Documents Add New workflow, formatting commands, and Release packaging behavior. |
| .vscode/settings.json | Adds spelling word, formatter defaults, and terminal auto-approve settings (currently invalid JSON). |
| .vscode/extensions.json | Recommends the CSharpier VS Code extension. |
Suppressed comments (1)
add-in/UGRC.UtransTools/UtransEditorDockpaneView.xaml:573
- UI label typo:
SPEED__LMThas a double underscore, but the field name and other UI labels use a single underscore (SPEED_LMT).
Header="SPEED__LMT"
💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.
stdavis
force-pushed
the
fix/add-in-feedback
branch
from
August 21, 2026 22:29
52deb16 to
930557d
Compare
acneville
approved these changes
Aug 24, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.