Check the contents of dictionary view annotations - #573
Open
RavSinghChandan wants to merge 1 commit into
Open
Conversation
KeysView, ValuesView and ItemsView had no checkers registered, so they fell through to a plain isinstance and their arguments were dropped: KeysView[int] accepted a view over string keys, and ItemsView[int, str] accepted the exact reverse of what it asked for. The views are checked elementwise like the other collections, and ItemsView follows check_mapping in reporting the key and the value separately.
|
coverage: 94.922% (+0.09%) from 94.83% — RavSinghChandan:check-dict-view-contents into agronholm:master |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
KeysView, ValuesView and ItemsView have no checkers registered, so their arguments get dropped:
The views are checked elementwise like the other collections. ItemsView follows check_mapping in reporting the key and the value separately