Check the contents of ChainMap, defaultdict and OrderedDict annotations - #574
Open
RavSinghChandan wants to merge 1 commit into
Open
Check the contents of ChainMap, defaultdict and OrderedDict annotations#574RavSinghChandan wants to merge 1 commit into
RavSinghChandan wants to merge 1 commit into
Conversation
These three had no checkers registered, so they fell through to a plain isinstance and their key and value types were dropped. A plain dict also passed for any of them, since nothing tested the concrete type. check_mapping already covers the contents and special-cases dict by origin, so the concrete types are looked up the same way rather than through three near-identical checkers. Counter is left alone: it takes a single argument and would need different handling.
|
coverage: 94.841% (+0.01%) from 94.83% — RavSinghChandan:check-mapping-subclass-contents into agronholm:master |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
None of the three have checkers registered, so their key and value types get dropped. A plain dict also passes for any of them, since nothing tests the concrete type:
check_mapping already covers the contents and special-cases dict by origin, so the concrete types are looked up the same way rather than through three near-identical checkers.
Counter is left alone here - it takes a single argument and needs different handling