fix(repos): run hygiene from invocation directory#118
Merged
Conversation
Use just invocation_directory() so repos::hygiene and repos::hygiene-prune audit the checkout the operator is standing in, not the dotfiles justfile directory. Fixes #117.
Add an integration test that runs hygiene from a subdirectory and cd to repo root in repos-smoke so the smoke script is caller-CWD independent.
Extract bookmark-pr-hygiene gh mocks into a shared helper so just contract tests and repos-smoke do not depend on live GitHub API access.
aguil
force-pushed
the
fix/repos-hygiene-invocation-dir
branch
from
e99759f to
c1ab6ce
Compare
aguil
force-pushed
the
fix/repos-hygiene-invocation-dir
branch
from
083919e to
c3bc89a
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
invocation_directory()inrepos::hygieneandrepos::hygiene-pruneso bookmark/PR hygiene audits the checkout the operator is standing in (including jj workspaces and git worktrees), not the dotfiles justfile directory.repos-smoke.shtocdto the repo root before invokingjust.docs/repo-maintenance.mdand the bookmark-pr-hygiene skill.Fixes #117.
Test plan
~/dev/projects/tmuxr/work(jj workspace):just repos::hygienedetects jj-workspace instead of failing with "not inside a jj or git repository"just -f qa.just test-shell-integration(hygiene tests needghAPI access)bash scripts/repos-smoke.shfrom an arbitrary CWD inside the dotfiles repoMade with Cursor