Skip to content

Buf Fix with DetectMobileQuick() in mdetect.php #15

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
jesseheap wants to merge 2 commits into
base: master
Choose a base branch
from
Open

Buf Fix with DetectMobileQuick() in mdetect.php #15

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
21bdb03
Bug fix with DetectMobileQuick() Function
jesseheap Jul 23, 2016
12f8662
Update mdetect.php
jesseheap Jul 23, 2016
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
7 changes: 4 additions & 3 deletions PHP/mdetect.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -4,7 +4,7 @@
// Copyright 2010-2015, Anthony Hand
//
//
// File version 2015.05.13 (May 13, 2015)
// File version 2016.07.23 (July 23, 2016)
// Updates:
// - Moved MobileESP to GitHub. https://github.com/ahand/mobileesp
// - Opera Mobile/Mini browser has the same UA string on multiple platforms and doesn't differentiate phone vs. tablet.
Expand Down Expand Up @@ -1086,7 +1086,8 @@ function DetectMobileQuick()
return $this->isMobilePhone;

//Let's exclude tablets
if ($this->isTierTablet == $this->true)
// Jesse Heap Patch: Prior code was using $this->isTierTablet which isn't set when running this the first time. Changed to DetectTierTablet which sets $this->isTierTablet
if ($this->DetectTierTablet() == $this->true)
return $this->false;

//Most mobile browsing is done on smartphones
Expand Down Expand Up @@ -1284,4 +1285,4 @@ function DetectTierOtherPhones()

//Was informed by a MobileESP user that it's a best practice
// to omit the closing ?> marks here. They can sometimes
// cause errors with HTML headers.
// cause errors with HTML headers.