Skip to content

Fix the framework's runtime edge cases and tighten its contract #73

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
ahegyes merged 33 commits into from
Nov 9, 2026
Merged

Fix the framework's runtime edge cases and tighten its contract #73

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
33 commits
Select commit Hold shift + click to select a range
fc0f423
Update packages
ahegyes Nov 9, 2026
82bf8ca
Test the guards that no row catches
ahegyes Nov 9, 2026
1cb4120
Test the updater's labels, stable channel, details and notice
ahegyes Nov 9, 2026
4669ce5
Test a build missing a bootstrap class
ahegyes Nov 9, 2026
90f4be3
Test cached entries naming a class that no longer loads
ahegyes Nov 9, 2026
41c181c
Test the scheduler on its own site and an uninitialized Action Scheduler
ahegyes Nov 9, 2026
9dbdd2c
Test the migration runner out of budget and its Run now link
ahegyes Nov 9, 2026
2ec471f
Test line breaks in interpolated log values
ahegyes Nov 9, 2026
57ffbdf
Test paged uninstall reads, term relationships and a failed run
ahegyes Nov 9, 2026
11c0718
Test that the object stores refuse objects
ahegyes Nov 9, 2026
86273f9
Test nested value objects of different classes
ahegyes Nov 9, 2026
bed7ae8
Test typed less-than signs, checked checkboxes and the rejection
ahegyes Nov 9, 2026
d4f01de
Test product radios and the ids WooCommerce rewrites
ahegyes Nov 9, 2026
9331e0b
Offer only lowercase-labelled releases and describe them in full
ahegyes Nov 9, 2026
c4e9eac
Return false from load.php when a bootstrap class is missing
ahegyes Nov 9, 2026
6d3ca26
Read a cached entry naming a missing class as a miss
ahegyes Nov 9, 2026
edf9881
Fall back from an old Action Scheduler and schedule on the own site
ahegyes Nov 9, 2026
7f0afff
End a spent migration run and keep its Run now link
ahegyes Nov 9, 2026
cce21a9
Escape line breaks in interpolated log values
ahegyes Nov 9, 2026
496f94a
Page uninstall reads, clear term relationships and report failures
ahegyes Nov 9, 2026
847e762
Keep only scalars, null and arrays in the framework stores
ahegyes Nov 9, 2026
71cb76f
Compare nested value objects only within one class
ahegyes Nov 9, 2026
ed83b44
Keep a typed '<', check on checkboxes and say the rest was saved
ahegyes Nov 9, 2026
3749770
Draw product radios through Forms and refuse ids WooCommerce rewrites
ahegyes Nov 9, 2026
58056ba
Drop PluginKernel::$resolved and name properties in the contract
ahegyes Nov 9, 2026
e97f762
Document SettingsSection's API, editor notice markup and grant timing
ahegyes Nov 9, 2026
5883ba2
Spell each shape, message, handle and name check once
ahegyes Nov 9, 2026
e582b30
Clean the uninstall footprint once
ahegyes Nov 9, 2026
5562c65
Inline Forms::sanitize_value() into sanitize_fields()
ahegyes Nov 9, 2026
ea876e8
Read a field row's id and title without fallbacks
ahegyes Nov 9, 2026
b47c7fb
Print the product panel's group wrapper once
ahegyes Nov 9, 2026
2c4734c
Require the bootstrap classes in load.php unchecked
ahegyes Nov 9, 2026
e0c14b8
Resolve the plugin's basename inside the floor notice
ahegyes Nov 9, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion .github/workflows/audit.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -18,4 +18,4 @@ jobs:
audit:
name: Audit
# npm's dev-dependency advisories surface through Dependabot alerts instead of failing this gate.
uses: ahegyes/wordpress-configs/.github/workflows/reusable-supply-chain-audit.yml@c944e73ab2656633397e7736ea104bbe72726ffd
uses: ahegyes/wordpress-configs/.github/workflows/reusable-supply-chain-audit.yml@b107001cce9f2960495d9d50481c8540d228f60c
2 changes: 1 addition & 1 deletion .github/workflows/codeql.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -21,4 +21,4 @@ jobs:
actions: read
contents: read
security-events: write
uses: ahegyes/wordpress-configs/.github/workflows/reusable-codeql.yml@c944e73ab2656633397e7736ea104bbe72726ffd
uses: ahegyes/wordpress-configs/.github/workflows/reusable-codeql.yml@b107001cce9f2960495d9d50481c8540d228f60c
10 changes: 5 additions & 5 deletions .github/workflows/quality.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -16,23 +16,23 @@ jobs:
name: Lint PHP
permissions:
contents: read
uses: ahegyes/wordpress-configs/.github/workflows/reusable-php-lint.yml@c944e73ab2656633397e7736ea104bbe72726ffd
uses: ahegyes/wordpress-configs/.github/workflows/reusable-php-lint.yml@b107001cce9f2960495d9d50481c8540d228f60c
with:
scripts: '["lint:php:phpcs", "lint:php:phpcs:tests", "lint:php:phpstan", "changelog:validate"]'

lint-scripts:
name: Lint scripts
permissions:
contents: read
uses: ahegyes/wordpress-configs/.github/workflows/reusable-scripts-styles-lint.yml@c944e73ab2656633397e7736ea104bbe72726ffd
uses: ahegyes/wordpress-configs/.github/workflows/reusable-scripts-styles-lint.yml@b107001cce9f2960495d9d50481c8540d228f60c
with:
scripts: '["lint:scripts"]'

php-syntax:
name: PHP 7.4 syntax (bootstrap)
permissions:
contents: read
uses: ahegyes/wordpress-configs/.github/workflows/reusable-php-syntax-check.yml@c944e73ab2656633397e7736ea104bbe72726ffd
uses: ahegyes/wordpress-configs/.github/workflows/reusable-php-syntax-check.yml@b107001cce9f2960495d9d50481c8540d228f60c
with:
php-versions: '["7.4"]'
paths: '["packages/bootstrap"]'
Expand Down Expand Up @@ -76,7 +76,7 @@ jobs:
needs: consumer-a-build
permissions:
contents: read
uses: ahegyes/wordpress-configs/.github/workflows/reusable-plugin-check.yml@c944e73ab2656633397e7736ea104bbe72726ffd
uses: ahegyes/wordpress-configs/.github/workflows/reusable-plugin-check.yml@b107001cce9f2960495d9d50481c8540d228f60c
with:
artifact: consumer-a
plugin-slug: acme-consumer-a
Expand All @@ -88,7 +88,7 @@ jobs:
needs: consumer-a-build
permissions:
contents: read
uses: ahegyes/wordpress-configs/.github/workflows/reusable-php-syntax-check.yml@c944e73ab2656633397e7736ea104bbe72726ffd
uses: ahegyes/wordpress-configs/.github/workflows/reusable-php-syntax-check.yml@b107001cce9f2960495d9d50481c8540d228f60c
with:
artifact: consumer-a
php-versions: '["7.4"]'
Expand Down
6 changes: 3 additions & 3 deletions .github/workflows/tests-nightly.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -12,7 +12,7 @@ permissions:
jobs:
integration:
name: Integration
uses: ahegyes/wordpress-configs/.github/workflows/reusable-phpunit.yml@c944e73ab2656633397e7736ea104bbe72726ffd
uses: ahegyes/wordpress-configs/.github/workflows/reusable-phpunit.yml@b107001cce9f2960495d9d50481c8540d228f60c
with:
php-version: '8.5'
wp-env-core: 'https://wordpress.org/nightly-builds/wordpress-latest.zip'
Expand All @@ -21,7 +21,7 @@ jobs:

integration-multisite:
name: Integration (multisite)
uses: ahegyes/wordpress-configs/.github/workflows/reusable-phpunit.yml@c944e73ab2656633397e7736ea104bbe72726ffd
uses: ahegyes/wordpress-configs/.github/workflows/reusable-phpunit.yml@b107001cce9f2960495d9d50481c8540d228f60c
with:
php-version: '8.5'
wp-env-core: 'https://wordpress.org/nightly-builds/wordpress-latest.zip'
Expand All @@ -30,7 +30,7 @@ jobs:

integration-woocommerce-nightly:
name: Integration (WooCommerce nightly)
uses: ahegyes/wordpress-configs/.github/workflows/reusable-phpunit.yml@c944e73ab2656633397e7736ea104bbe72726ffd
uses: ahegyes/wordpress-configs/.github/workflows/reusable-phpunit.yml@b107001cce9f2960495d9d50481c8540d228f60c
with:
php-version: '8.5'
composer-script: 'test:integration:woocommerce-nightly:run'
Expand Down
12 changes: 6 additions & 6 deletions .github/workflows/tests.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -16,7 +16,7 @@ permissions:
jobs:
unit:
name: Unit
uses: ahegyes/wordpress-configs/.github/workflows/reusable-phpunit.yml@c944e73ab2656633397e7736ea104bbe72726ffd
uses: ahegyes/wordpress-configs/.github/workflows/reusable-phpunit.yml@b107001cce9f2960495d9d50481c8540d228f60c
with:
php-version: '8.5'
composer-script: 'test:unit'
Expand Down Expand Up @@ -51,7 +51,7 @@ jobs:
fail-fast: false
matrix:
wp: ${{ fromJSON(needs.wordpress.outputs.versions) }}
uses: ahegyes/wordpress-configs/.github/workflows/reusable-phpunit.yml@c944e73ab2656633397e7736ea104bbe72726ffd
uses: ahegyes/wordpress-configs/.github/workflows/reusable-phpunit.yml@b107001cce9f2960495d9d50481c8540d228f60c
with:
php-version: '8.5'
wp-version: ${{ matrix.wp }}
Expand All @@ -65,7 +65,7 @@ jobs:
fail-fast: false
matrix:
wp: ${{ fromJSON(needs.wordpress.outputs.versions) }}
uses: ahegyes/wordpress-configs/.github/workflows/reusable-phpunit.yml@c944e73ab2656633397e7736ea104bbe72726ffd
uses: ahegyes/wordpress-configs/.github/workflows/reusable-phpunit.yml@b107001cce9f2960495d9d50481c8540d228f60c
with:
php-version: '8.5'
wp-version: ${{ matrix.wp }}
Expand All @@ -79,7 +79,7 @@ jobs:
fail-fast: false
matrix:
wp: ${{ fromJSON(needs.wordpress.outputs.versions) }}
uses: ahegyes/wordpress-configs/.github/workflows/reusable-playwright-e2e.yml@c944e73ab2656633397e7736ea104bbe72726ffd
uses: ahegyes/wordpress-configs/.github/workflows/reusable-playwright-e2e.yml@b107001cce9f2960495d9d50481c8540d228f60c
with:
artifact-slug: wp-${{ matrix.wp }}
php-version: '8.5'
Expand All @@ -89,15 +89,15 @@ jobs:

integration-php74:
name: Integration (PHP 7.4)
uses: ahegyes/wordpress-configs/.github/workflows/reusable-phpunit.yml@c944e73ab2656633397e7736ea104bbe72726ffd
uses: ahegyes/wordpress-configs/.github/workflows/reusable-phpunit.yml@b107001cce9f2960495d9d50481c8540d228f60c
with:
php-version: '8.5'
composer-script: 'test:integration:php74:run'
wp-env-config-file: '.wp-env.php74.json'

prefer-lowest:
name: Prefer lowest
uses: ahegyes/wordpress-configs/.github/workflows/reusable-phpunit.yml@c944e73ab2656633397e7736ea104bbe72726ffd
uses: ahegyes/wordpress-configs/.github/workflows/reusable-phpunit.yml@b107001cce9f2960495d9d50481c8540d228f60c
with:
php-version: '8.5'
composer-script: 'test:integration:lowest:run'
Expand Down
2 changes: 1 addition & 1 deletion .github/workflows/workflow-checks.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -24,4 +24,4 @@ jobs:
contents: read
security-events: write
actions: read
uses: ahegyes/wordpress-configs/.github/workflows/reusable-workflow-checks.yml@c944e73ab2656633397e7736ea104bbe72726ffd
uses: ahegyes/wordpress-configs/.github/workflows/reusable-workflow-checks.yml@b107001cce9f2960495d9d50481c8540d228f60c
Loading
Loading