Modify function input parameter type and event parameter type #13
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hi Alexander Houben sir,
I noticed some enums was not be used, so I change some functions' input parameter type to enum,
and change some events' parameter type to enum too.
Unfortunately, I don't have any BLE device to make some unit tests for now.
Hope it's helpful to you.
changed functions:
ble_cmd_system_endpoint_tx
ble_cmd_system_whitelist_append
ble_cmd_system_whitelist_remove
ble_cmd_system_endpoint_rx
ble_cmd_system_endpoint_set_watermarks
ble_cmd_sm_set_parameters
ble_cmd_gap_set_mode
ble_cmd_gap_discover
ble_cmd_gap_set_filtering
ble_cmd_gap_set_directed_connectable_mode
changed events:
ble_msg_attributes_value_evt_t
ble_msg_attributes_status_evt_t
ble_msg_connection_status_evt_t
ble_msg_attclient_attribute_value_evt_t
ble_msg_sm_bond_status_evt_t
Best Regards,
Chieh-Lung Sung