Repository navigation
Enforce state budgets, post-death run_late parity, must_fail gate, and LINT_PASS (#53 A3/A4/A6/A7) - #60
Merged
Conversation
…d LINT_PASS (#53 A3/A4/A6/A7)
Open
25 tasks
zero-aska
approved these changes
Nov 19, 2026
zero-aska
left a comment
Collaborator
There was a problem hiding this comment.
Approve at 537e59e. Cloud review bc-2e58906b, run 2.
This approves the gate behaviour and the corpse-render parity fix from the earlier review, now with main (3ea918f) merged in normally, with no force-push. The only conflict was SHA256SUMS, which was regenerated with soko_mcp.integrity --write.
| Check | Head | main 3ea918f |
|---|---|---|
soko_mcp.integrity |
PASS 21/21 | |
| Targeted pytest | 54/54 | |
unittest discover |
307 ran, 3 failures, 20 errors | 297 ran, 3 failures, 22 errors |
The 3 failures are the same C++ landmark/transport compile failures as on main, and the errors come from optional experiments/ imports. This head adds no new failures.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Close the remaining open verification-discipline items from #53 (
A3test_07wall-clock budget,A4post-death nativerun_lateparity,A6must_failcertificate controls and tier-swap gate, andA7static checker-auditorLINT_PASSstatus) without touching search results orformal_kernel.py.What Changed
soko_optimize_routeandtest_07): Added optional per-stagemax_statescap (budget_sec=0disables wall-clock cutoffs) incpp/soko_engine.cpp,soko_mcp/engine_bridge.py, andsoko_mcp/server.py.test_07now reproducesIII-2087 -> 84viamax_states=6000000, budget_sec=0, andsoko_engine.cppuses standard C++20 headers for GCC and Clang compatibility.run_lateparity incpp/soko_engine.cpp): Replaced early hero-death returns inrun_latewithOBJ_CORPSE('X') so simultaneous monster kills, door transitions, monster gates, and Bard notes matchPuzzleScriptOracle._run_late. Enabled unconditionalfinal_asciichecks across all528sampled catalog routes intests/test_engine_differential.py(test_perft.pyandtest_bench.pystay intact).must_failcontrols and tier-swap gate): Addedmust_failandverify_certificate_gateinsoko_mcp/evidence.py, recorded live dual-oracle and gatemust_fail_controlspluscertificate_sha256digests inengine_bridge.pyandtracks/*/verify.py, and addedtests/test_certificate_corruptions.pycatching missing controls, hash tampering, tautological seeded controls, andLOWER_BOUND/LINT_PASS->VERIFIEDtier swaps.LINT_PASSon static checker audits): Relabeledaudit_dual_checkersandaudit_builtin_soko_oraclesinsoko_mcp/checker_auditor.pyfromVERIFIEDtoLINT_PASS, and refreshedSHA256SUMSviapython3 -m soko_mcp.integrity --write.What Is Not Proved
LINT_PASSchecks static AST separation and exact-math syntax rather than semantic equivalence between checkers.LOWER_BOUND_UNWITNESSEDrefutes shorter routes under the engine's runtime-checked heuristic without proving a winning route exists at that bound.Verification
python3 -m soko_mcp.integrity(21/21locked sources verified)mde guard --code-audit(0findings across all10touched Python modules and tests)python3 -O -B -m pytestacrosstest_certificate_corruptions.py,test_v04_foundation0_synthesis.py,test_mcp_server.py,test_engine_differential.py,test_perft.py,test_bench.py,test_f04_close.py,test_optimize_seed.py, andtest_integrity.py(54passed,612subtests passed)