Repository navigation
Conversation
Replays every catalogued reference route and checks, at each state, that the bound does not exceed the keys still to play, drops by at most 1 per key, and is 0 at the goal. Covers the operator-counting bound on all 66 rooms, the III-21 retrograde tablebase and the III-14 vault tablebase. Must-fail controls: a switch-cycle quotient on the III-21 record, five passive-move boards, the withdrawn soko#38 bound, the unpartitioned Manhattan sum and corrupted operator-counting values.
…ate floor check The catalogued floor is already checked against the best known route in tests/test_catalog.py, and the added check that it could fail did not call the guarded code. The switch automaton control now lists all 19 steps with no abstract edge, and a second control runs the automaton's exact distance through the gate, which reports a drop of more than 1 at keys 241, 243, 289 and 310.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #71
What this adds
One new file,
tests/test_bound_route_soundness.py. No other file changes, and no file listed inSHA256SUMSis touched.For each route in the catalog it replays the keys through the oracle and checks three conditions at every state, with exact integers or fractions:
It runs these on the operator-counting bound over all 66 catalogued rooms, the III-21 retrograde tablebase on the 316-key route and the III-14 vault tablebase on the 48-key route.
Controls that must be rejected
Verified
All three exit 0. The first two run 9 tests. The test uses no bare
assert, so it runs unchanged under-O.Each control was also checked against a broken gate. With
gatechanged to report nothing, four controls fail. With the edge check changed to accept every step, the other two fail.Result on current main
The operator-counting bound and both tablebases show no violation on any catalogued route. The checks see only states on the routes, so they do not show that a bound holds elsewhere.