[AAASM-2774] 🔧 (sonar): Wire projectVersion off 0.0.0 + cover in release skills#203
Conversation
0.0.0 stalls the SonarCloud quality gate at "Not computed". Set the static fallback to the current package version and document that CI overrides it. Refs AAASM-2774 Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_019mSz31RysZF6DYToUoBWLf
Pass -Dsonar.projectVersion=<package.json version> to the Sonar scan so the quality gate auto-advances each release instead of being pinned to a literal. Refs AAASM-2774 Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_019mSz31RysZF6DYToUoBWLf
Note in both release runbooks that quality-report.yml derives sonar.projectVersion from package.json, so no manual bump is needed on the release path; keep the static fallback roughly in step. Refs AAASM-2774 Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_019mSz31RysZF6DYToUoBWLf
Codecov Report✅ All modified and coverable lines are covered by tests. 📢 Thoughts on this report? Let us know! |
|
🤖 Claude Code — PR Review (AAASM-2774)CI: All checks green (test 18/20/22/24, napi-build, module-smoke, quality, coverage-and-analysis, SonarCloud Code Analysis, CodeQL, audit). Scope: Correct and minimal — Side-effects / injection-safety: ✅ The resolve step reads only in-repo content — Verdict: APPROVE-READY |



Target
Fix the SonarCloud quality gate showing "Not computed" on
node-sdk, caused bysonar.projectVersion=0.0.0insonar-project.properties, and make the version self-maintaining across releases.Task summary:
sonar.projectVersionoff0.0.0(static fallback now0.0.1-rc.1, the currentpackage.jsonversion).sonar.projectVersionfrompackage.json(-Dsonar.projectVersion=<version>), so the gate auto-advances every release with no manual bump.Task tickets:
Key point change (optional):
.github/workflows/quality-report.yml: newResolve package version for Sonarstep readspackage.jsonversioninto a step output; theSonarQube Scanstep passes it viaargs: -Dsonar.projectVersion=.... This overrides the static value at scan time, so the gate version always trackspackage.json.sonar-project.properties:0.0.0->0.0.1-rc.1, kept only as a fallback (the CI override is authoritative). Annotated so it stays off0.0.0..claude/skills/release-runbook/SKILL.md+.claude/skills/sdk-only-release/SKILL.md: note thatsonar.projectVersionis auto-derived frompackage.json-- no manual bump required on the release path.Effecting Scope
Config + workflow + docs only; no source or test changes. Validated with
pnpm install,pnpm lint,pnpm typecheck(all clean).Description
sonar.projectVersion=0.0.0left the SonarCloud gate "Not computed". This sets a real version and, more importantly, wires CI to derive it frompackage.jsonso it auto-advances each release. Both release runbooks now document the auto-derive so the gate never regresses to0.0.0.Closes AAASM-2774
🤖 Generated with Claude Code