[AAASM-3879] 🔧 (ci): Pin checkout + add least-priv permissions#209
Draft
Chisanan232 wants to merge 2 commits into
Draft
[AAASM-3879] 🔧 (ci): Pin checkout + add least-priv permissions#209Chisanan232 wants to merge 2 commits into
Chisanan232 wants to merge 2 commits into
Conversation
Pin the lone unpinned `actions/checkout@v7` to the v7.0.0 commit SHA already used by every other workflow in this repo, so a mutable-tag move cannot alter the checkout step. Refs AAASM-3879 Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_019mSz31RysZF6DYToUoBWLf
Add a top-level `permissions: contents: read` block to the five CI workflows that lacked one (build-addon, test-matrix, module-system-smoke, precommit, regression). All only build/test, so read-only is sufficient and revokes the default broad GITHUB_TOKEN scope. Refs AAASM-3879 Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_019mSz31RysZF6DYToUoBWLf
Codecov Report✅ All modified and coverable lines are covered by tests. 📢 Thoughts on this report? Let us know! |
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Target
Task summary:
Harden node-sdk CI step-action pinning and least-privilege token scope. Part 2 of 2 for AAASM-3879 (the python-sdk half ships as a separate PR, 🤖 (aa-ffi-node): Bump agent-assembly git pins to v0.0.1-beta.4 #193).
Task tickets:
Key point change:
native-pin-consistency.yml: pin the lone unpinnedactions/checkout@v7→@9c091bb21b7c1c1d1991bb908d89e4e9dddfe3e0 # v7.0.0(the SHA already used by every other workflow in this repo).permissions: contents: readblock tobuild-addon,test-matrix,module-system-smoke,precommit,regression— they only build/test, so read-only is sufficient and revokes the default broadGITHUB_TOKENscope.Effecting Scope
CI-config-only;
actionlintclean on all six modified workflows.Description
Refs AAASM-3879
🤖 Generated with Claude Code
https://claude.ai/code/session_019mSz31RysZF6DYToUoBWLf