Skip to content

[AAASM-3815] 🔧 (sonar): Wire projectVersion off 0.0.0 + cover in release skills#188

Merged
Chisanan232 merged 4 commits into
masterfrom
v0.0.1/AAASM-3815/sonar_projectversion
Jun 26, 2026
Merged

[AAASM-3815] 🔧 (sonar): Wire projectVersion off 0.0.0 + cover in release skills#188
Chisanan232 merged 4 commits into
masterfrom
v0.0.1/AAASM-3815/sonar_projectversion

Conversation

@Chisanan232

Copy link
Copy Markdown
Contributor

Description

Fixes the SonarCloud quality gate showing "Not computed" for python-sdk,
caused by sonar.projectVersion=0.0.0 in sonar-project.properties.

  • sonar-project.properties: bump the static sonar.projectVersion off 0.0.0
    to 0.0.1 (local-scan fallback only).
  • rw_run_all_test_and_record.yaml (SonarCloud Scan job): derive the version
    from pyproject.toml at scan time and pass it via the scanner args
    (-Dsonar.projectVersion=...), so the gate always tracks the current
    release
    without manual bumps. The step reads only in-repo content (no
    untrusted event input).
  • Release skills (release-runbook, sdk-only-release): document the
    auto-derivation so operators do not hand-bump the literal per release.

Type of Change

  • 🔧 Bug fix

Breaking Changes

  • No

Related Issues

  • Related JIRA ticket: AAASM-3815

Testing

  • No tests required (explain why)

CI/config + docs change. The edited workflow passes actionlint cleanly. No
application code changed.

Checklist

  • Code follows project style guidelines
  • Self-review completed
  • Documentation updated if needed

Closes AAASM-3815

🤖 Generated with Claude Code

https://claude.ai/code/session_019mSz31RysZF6DYToUoBWLf

Chisanan232 and others added 3 commits June 26, 2026 17:52
A literal sonar.projectVersion=0.0.0 leaves the SonarCloud quality gate
stuck at "Not computed". Use 0.0.1 as the local-scan fallback; CI overrides
it dynamically with the live pyproject.toml version.

Closes AAASM-3815

Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>
Claude-Session: https://claude.ai/code/session_019mSz31RysZF6DYToUoBWLf
Derive sonar.projectVersion from pyproject.toml in the SonarCloud Scan job
and pass it via the scanner args, so the quality gate always tracks the
current release instead of the static fallback in sonar-project.properties.

Refs AAASM-3815

Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>
Claude-Session: https://claude.ai/code/session_019mSz31RysZF6DYToUoBWLf
… skills

Document in release-runbook and sdk-only-release that the SonarCloud Scan job
derives sonar.projectVersion from pyproject.toml, so operators must not
hand-bump the sonar-project.properties literal per release (it is the
local-scan fallback only, kept off 0.0.0).

Refs AAASM-3815

Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>
Claude-Session: https://claude.ai/code/session_019mSz31RysZF6DYToUoBWLf
@codecov

codecov Bot commented Jun 26, 2026

Copy link
Copy Markdown

Codecov Report

✅ All modified and coverable lines are covered by tests.

📢 Thoughts on this report? Let us know!

@Chisanan232

Copy link
Copy Markdown
Contributor Author

🤖 Claude Code — PR Review (AAASM-3815)

CI: All checks green (CI Success aggregate ✅, unit/integration tests, codecov, SonarCloud Code Analysis, CodeQL, pip-audit).

Scope: Correct and minimal — sonar-project.properties 0.0.00.0.1; rw_run_all_test_and_record.yaml derives the version from pyproject.toml and overrides via -Dsonar.projectVersion=…; both release skills (release-runbook, sdk-only-release) document the auto-derive. Diff limited to sonar config + Sonar CI step + skills — no source/test changes. Closes AAASM-3815 present.

Side-effects / injection-safety: ✅ Resolve step reads only in-repo content — grep … pyproject.toml | sed … — no untrusted GitHub event input, no injection surface, and it fails closed (exit 1) if the version can't be parsed. The SonarCloud Scan job was not made gating. Workflow parses (CI green).

Verdict: APPROVE-READY

@Chisanan232 Chisanan232 marked this pull request as ready for review June 26, 2026 10:05
Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>
Claude-Session: https://claude.ai/code/session_019mSz31RysZF6DYToUoBWLf
@Chisanan232

Copy link
Copy Markdown
Contributor Author

Amended: the static sonar.projectVersion fallback in sonar-project.properties was a bare 0.0.1; it now matches the repo's real current version 0.0.1rc1 from pyproject.toml (PEP 440). The dynamic CI override (live pyproject version via -Dsonar.projectVersion=...) was already correct — this fixes the local-scan fallback so it no longer diverges from the real release.

Commit cc15287: 🔧 (sonar): Align static fallback to real pyproject version 0.0.1rc1. Pre-commit passed; pushed to remote. PR kept ready, not merged.

@sonarqubecloud

Copy link
Copy Markdown

@Chisanan232 Chisanan232 merged commit 9d69456 into master Jun 26, 2026
21 checks passed
@Chisanan232 Chisanan232 deleted the v0.0.1/AAASM-3815/sonar_projectversion branch June 26, 2026 10:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant