Ci/release notes from changelog - #27
Merged
Merged
Conversation
`napi prepublish` creates the release with neither a name nor a body, so every release it
made was untitled and empty. Extract the section for the version being released and set it
on the release after publishing.
The tag pattern now requires the `v` prefix. napi derives the release tag as `v${version}`
regardless of what was pushed, so a bare `0.24.0` tag made it create a second `v0.24.0` tag
and release pointing at whatever the default branch happened to be.
Co-Authored-By: Claude Opus 5 (1M context) <noreply@anthropic.com>
0.23.1 and every package before it were published by trusted publishing: npm records the publisher as `GitHub Actions <npm-oidc-no-reply@github.com>`, and the old workflow carried no token, only `id-token: write` and an npm new enough to use it. The rewrite replaced that with an `_authToken` line, so the release ran unauthenticated and npm answered the `PUT` with a 404 for a package that plainly exists. Drop the token, install an npm that supports trusted publishing, and let the OIDC identity authenticate. Provenance is no longer set explicitly because trusted publishing attaches it anyway, which is how 0.23.1 got its attestation. Also skip the root publish when that version is already on the registry, so a release that failed partway can be re-run. `napi prepublish` already does this for the platform packages. Co-Authored-By: Claude Opus 5 (1M context) <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.