Skip to content

[Aikido] AI Fix for Path traversal attack possible #31

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
aikido-autofix wants to merge 1 commit into from
Closed

[Aikido] AI Fix for Path traversal attack possible #31

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
10 changes: 9 additions & 1 deletion src/model.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -48,8 +48,16 @@ impl Model {
/// @throws If the file cannot be loaded or its format is incompatible with this SDK.
#[napi(factory)]
pub fn from_file(env: Env, path: String) -> Result<Self> {
// Prevent path traversal attacks by rejecting paths containing '..'.
let path_ref = std::path::Path::new(&path);
if path_ref.components().any(|c| c == std::path::Component::ParentDir) {
return Err(map_err(std::io::Error::new(
std::io::ErrorKind::InvalidInput,
format!("Invalid input: {}", path_ref.display())
)));
}
let inner = map_err(aic_sdk::Model::from_file(&path))?;
let bytes = mem::model_bytes(std::path::Path::new(&path));
let bytes = mem::model_bytes(path_ref);

Ok(Self {
slot: DisposableSlot::new(env, inner, "Model", bytes),
Expand Down
Loading