Skip to content

Prepare crates io release - #18

Merged
steckes merged 9 commits into
mainfrom
prepare-crates-io-release
Sep 9, 2026
Merged

steckes merged 9 commits into
mainfrom
prepare-crates-io-release

Conversation

@steckes

@steckes steckes commented Sep 9, 2026

Copy link
Copy Markdown
Contributor

No description provided.

Comment thread README.md Outdated
Comment thread README.md Outdated
cargo add --build lib-patcher
```

Then use it programmatically in your `build.rs`:

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We should maybe stress that this is for patching an already compiled library (what the "thirdparty" name already hints at), not for patching the library that's currently built.

I was a bit confused by this ...

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is this too long?

Use it in your `build.rs` to patch an **already compiled external static library**
before linking it into your crate. In the example below, `vendor/libthirdparty.a`
must already exist.

This does **not** patch the library produced by the current crate: Cargo runs
`build.rs` before compiling that crate, so its output library is not available yet.
To patch your own crate's static library, first build it, then use the
[CLI tool](#as-a-cli-tool-post-build) as a separate post-build step.

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I like it!

@mgeier

mgeier commented Sep 9, 2026

Copy link
Copy Markdown
Contributor

I'm not sure if caching is even necessary in quality.yml. I might save a few tens of seconds while not being the bottleneck. OTOH, the workflow file gets simpler when dropping all the cache-related stuff.

@steckes
steckes merged commit 5ddb536 into main Sep 9, 2026
10 checks passed
@steckes
steckes deleted the prepare-crates-io-release branch September 9, 2026 12:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants