Repository navigation
feat(kit): add the AIDD Docker Sandbox kit - #1042
Draft
crocogiciel wants to merge 4 commits into
Draft
crocogiciel wants to merge 4 commits into
crocogiciel wants to merge 4 commits into
Conversation
crocogiciel
marked this pull request as draft
October 16, 2026 13:39
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
🎯 What & why
Ships
kits/aidd/as a Docker Sandbox mixin kit: one command installs the AIDD framework's recommended plugins into aclaude-codesandbox, Claude-only, so it survives the runtime's settings overwrite.🛠️ How it works
kits/aidd/spec.yaml(schemaVersion"2",kind: mixin) runs twosetup.installsteps as the sandbox's ownclaudeCLI, not theaiddnpm CLI — no Node/pnpm dependency inside the sandbox image, and it matches the proof of concept already validated on the issue.claudebeing present, thenclaude plugin marketplace add+ aclaude plugin installloop over the recommended plugins.aidd-ui,aidd-telemetryandaidd-qaare deliberately left out (alpha/beta/unproven) — opt in by name after install.~/.claude/settings.jsonwith the host's own file at every session start, so step 1's install alone leaves every plugin disabled once a real session starts. Step 2 mergesextraKnownMarketplaces+enabledPluginsinto/etc/claude-code/managed-settings.jsoninstead, which the runtime does not overwrite — merged, not written, since the base image or another kit may already hold content there.scripts/__tests__/kit-aidd-managed-settings.test.jsreads both commands straight out ofspec.yaml(not a re-typed copy) and asserts:aidd-uiis never in the install list, and the merge keeps unrelated managed-settings keys while adding the AIDD wiring, including the missing-file and missing-user-file edge cases.CI gets two jobs in
ci.yml:validate-kit(sbx kit validate, every PR) andbuild-and-push-kit(gated onrelease-please'srelease_created, pushesghcr.io/ai-driven-dev/aidd-sbx-kit:<version>and:latest).Known gap, not fixable from this PR:
build-and-push-kitneeds aGHCR_PACKAGES_TOKENrepo secret (a PAT withwrite:packages) — pushing a brand-new non-container OCI artifact withGITHUB_TOKENalone 403s on package creation, confirmed against a working reference implementation. An org admin has to add that secret before this job can succeed on the first real release.🧪 How to verify
sbx kit validate kits/aidd→VALID: kits/aidd (directory).node scripts/check-tests-leave-git-alone.js -- node --test 'scripts/__tests__/kit-aidd-managed-settings.test.js'→ 4 passing.sbx run claude-code --kit ./kits/aiddagainst this checkout to install it into a real sandbox.GHCR_PACKAGES_TOKENsecret still needs to be added to the repo beforebuild-and-push-kitcan succeed — see above.versioninspec.yamlis bumped by hand, decoupled from release-please; it is the pin pointsbx kit add/pushtag on.🔗 Linked issue
Closes #678
✅ I certify
🤖 Generated with Claude Code