[BlandineRdl]

🎯 What & why

aidd-dev:06-test told the agent to check a passing test "against the quality criteria" without defining them. A green test that only echoes a mock's return value, or only asserts a mock was called, satisfied the contract while protecting nothing.

🛠️ How it works

plugins/aidd-dev/skills/06-test/actions/01-test.md gains a ## Quality criteria section, language-independent:

• Project conventions win: a documented rule or the test configuration, never a pattern found in existing tests; any deviation is noted beside the test.
• Observable behavior: no test that checks only internal structure, calls to a stub, or a collaboration graph without computed values.
• Real subject: the logic under test is never doubled.
• Doubles at seams: a first-match decision list per dependency, so no two rules conflict: never double the subject; mock an outgoing command only for that call; double a boundary only through a seam (port, adapter with no domain logic, or the framework's own interception such as fake timers); with no seam, never patch the subject, the behavior goes pending with missing seam at <dependency> once the user agrees; everything else, domain collaborators included, stays real.
• Stub queries, mock commands: never assert on a stub; asserting a mock's call, with computed values, is legitimate when the call is the behavior.
• No tautology: mock-return/assert arrangements are rejected.
• Effectiveness: each test names a break that keeps the subject running. Behaviors scored 4-5 must run it (apply, watch it fail, restore and compare against a copy, rerun green); below 4 a reasoned check with its reason is accepted. Mutation testing only if the project already configures it; nothing is installed.

List and Approve now show and approve each behavior's score, since the score decides run vs reasoned. SKILL.md and 02-test-journey are untouched.

🧪 How to verify

• pnpm exec lefthook run pre-commit: green on every commit (doc-duplication, markdown-links, referenced-paths, scripts-tests, recipe-validity, commitlint).
• Independent reviews against the acceptance criteria of feat(aidd-dev/test): enforce test effectiveness and test-double discipline #952: all eight met, out-of-scope respected. Contradictions and loopholes found along the way were fixed.

⚠️ Heads-up

• No structural test guards this text; nothing in the repository requires one.
• A blind old-vs-new A/B (Sonnet, Haiku) ran on an earlier revision of this action and showed no measurable gain on a fixture with clean injected seams. A fixture with hard-wired dependencies is still needed to exercise the missing-seam rules.

🔗 Linked issue

Closes #952

✅ I certify

• I DO CERTIFY I READ EACH LINE OF THE PULL REQUEST BECAUSE I AM A SOFTWARE ENGINEER, NOT A AI PUPPY.

🤖 Generated with Claude Code