Skip to content

test(cli): prove every target build leaves model selection to the host - #1086

Open
BlandineRdl wants to merge 1 commit into
ai-driven-dev:nextfrom
BlandineRdl:refactor/model-host-inheritance
Open

BlandineRdl wants to merge 1 commit into
ai-driven-dev:nextfrom
BlandineRdl:refactor/model-host-inheritance

Conversation

@BlandineRdl

@BlandineRdl BlandineRdl commented Oct 23, 2026 •

Copy link
Copy Markdown
Contributor

🎯 What & why

#989 removed the seven opus/sonnet pins and guards the plugin sources. Two Done-when items of #677 remained: no proof that built distributions carry no framework model override, and no documented statement that the user and host own model and reasoning selection.

🛠️ How it works

  • cli/tests/e2e/framework-model-inheritance.e2e.test.ts translates the shipped repository for every target/mode frameworkBuildTargetModes() announces (10 today), and fails on any emitted frontmatter model: or .toml model =. Cells come from the registry, so a new build mode is guarded on arrival.
  • docs/ARCHITECTURE.md Portability table gains a "Model selection" row linking the source guard and the build guard.

🧪 How to verify

  • cd cli && pnpm build && npx vitest run --project=e2e tests/e2e/framework-model-inheritance.e2e.test.ts => 10 passed.
  • Mutation: adding model: opus to plugins/aidd-dev/agents/checker.md => 8 failed, 2 passed (both Codex cells drop model by design).
  • pnpm exec lefthook run pre-commit => all green.

⚠️ Heads-up

  • cli/tests/fixtures/framework-real keeps its model pins: it is the frozen v4.1.0-beta.12 snapshot feeding the golden matrix, and it keeps proving user-authored model fields survive translation.
  • Model examples in the token-optimization recipe sit in code blocks, not frontmatter; they are user guidance and stay.

🔗 Linked issue

Closes #677

✅ I certify

  • I DO CERTIFY I READ EACH LINE OF THE PULL REQUEST BECAUSE I AM A SOFTWARE ENGINEER, NOT A AI PUPPY.

🤖 Generated with Claude Code

Builds the shipped plugins for every registered target, marketplace and
flat, and fails on any emitted frontmatter or TOML model declaration.
Documents in the portability contract that the user and host own the
concrete model and reasoning settings.

Refs ai-driven-dev#677

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
@BlandineRdl
BlandineRdl marked this pull request as ready for review October 23, 2026 12:19
@BlandineRdl
BlandineRdl requested a review from a team as a code owner October 23, 2026 12:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant