Repository navigation
test: stop the comment-names-files check from failing on a vanishing scratch directory - #1124
Merged
Merged
Conversation
…scratch directory find exits 1 on a directory that disappears while it scans, as another test's scratch directory does. The check now keeps what find listed before stopping and leaves scratch directories out of the scan. Co-Authored-By: Claude Sonnet 5.5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01XeK3mFt8TGPAoKbzZAsaNf
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
🎯 What & why
comments-name-files-that-exist.test.js failed at random when another test's scratch directory disappeared while it scanned the tree:
findexits 1 on a directory that vanishes, and the test threw instead of using what it had already listed.🛠️ How it works
findexiting 1 now keeps what it printed before stopping; any other failure still throws..tmp-*) is no part of the repository, so it is left out of the scan.🧪 How to verify
node scripts/check-tests-leave-git-alone.js -- node --test scripts/__tests__/comments-name-files-that-exist.test.js✅ I certify
🤖 Generated with Claude Code
https://claude.ai/code/session_01XeK3mFt8TGPAoKbzZAsaNf