Repository navigation
test: strip template comments without a regex in the implement tests - #1127
Merged
Merged
Conversation
Code scanning flagged the comment-stripping regular expression and a helper left unused. The comments are now stripped with the same small loop the plan tests use, and the helper is removed. Co-Authored-By: Claude Sonnet 5.5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01XeK3mFt8TGPAoKbzZAsaNf
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
🎯 What & why
Code scanning flagged two new alerts in validate-implement.test.js after the implement skill merged: a regular expression that strips HTML comments (incomplete multi-character sanitization) and a variable left unused after tests were dropped.
🛠️ How it works
indexOfloop the plan tests already use, not a regex.🧪 How to verify
node scripts/check-tests-leave-git-alone.js -- node --test scripts/__tests__/validate-implement.test.js(63 tests)✅ I certify
🤖 Generated with Claude Code
https://claude.ai/code/session_01XeK3mFt8TGPAoKbzZAsaNf