Repository navigation
fix(cli): give integration hooks the same timeout as integration tests - #1132
Merged
Merged
Conversation
A beforeEach that spawns git ran past vitest's 10s hook default on a loaded Windows runner, while tests already had 60s. Co-Authored-By: Claude Sonnet 5.5 <noreply@anthropic.com>
The hook only finds aidd through PATHEXT there, so the extensionless stand-in was skipped and a globally installed aidd answered instead. Without one, the hand key and copy rows failed. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
🎯 What & why
Give the
integrationvitest project a 60shookTimeout, matching itstestTimeout. AbeforeEachthat spawns git hit vitest's 10s hook default on a loaded Windows runner, while the tests it sets up already had 60s.🛠️ How it works
telemetry-lifecycle.integration.test.tsbuilds a throwaway git repository inbeforeEach(init,remote add,commit). Under the full integration project on Windows the spawn cost roughly doubles against an idle machine, and one stall past 10s failed the hook. The rerun passed.consent-scenariosandtelemetry-lifecycle, hold about three quarters of the project's spawned processes, so they carry most of the exposure.retry(would hide real flakes), and--max-workers=2(no consistent gain measured).vitest.mutation.config.tstoo, since it declares its ownintegrationproject.consent-scenarioswrote its stand-inaiddas an extensionless shebang file. The hook only findsaiddthroughPATHEXTon Windows, so the stand-in was skipped and a globally installedaiddanswered instead; without one, thehand keyandcopy at the pathrows failed. On Windows it now writesaidd.cmdwith its CLI entry beside it, whichresolveAiddruns with node.🧪 How to verify
cd cli && pnpm exec vitest run --project integration tests/contexts/telemetry/telemetry-lifecycle.integration.test.ts tests/contexts/telemetry/consent-scenarios.integration.test.tsaiddonPATH, the consent scenarios pass.e2ehas the same gap and no observed failure, so it is untouched.✅ I certify
🤖 Generated with Claude Code