docs: update vLLM loader registration docs#390
Conversation
NVBug: 6235739 Signed-off-by: Zheng Luo <zheluo@nvidia.com>
NVBug: 6235844 Signed-off-by: Zheng Luo <zheluo@nvidia.com>
d92ae01 to
8d04e09
Compare
AndyDai-nv
left a comment
There was a problem hiding this comment.
LGTM, let's wait for CI
|
Actionable comments posted: 0 |
|
No actionable comments were generated in the recent review. 🎉 ℹ️ Recent review info⚙️ Run configurationConfiguration used: Path: .coderabbit.yaml Review profile: CHILL Plan: Pro Run ID: 📒 Files selected for processing (23)
💤 Files with no reviewable changes (1)
WalkthroughDocumentation and Kubernetes deployment examples updated to standardize vLLM load-format terminology from ChangesLoad Format Naming Standardization
Estimated code review effort🎯 2 (Simple) | ⏱️ ~12 minutes Poem
🚥 Pre-merge checks | ✅ 5✅ Passed checks (5 passed)
✏️ Tip: You can configure your own custom pre-merge checks in the settings. Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
Summary
--load-format modelexpressas the canonical vLLM load format andmxas the backward-compatible alias.mx-source/mx-targetreferences and obsolete--worker-clsquick-start usage.MX_REGISTER_LOADERSdocs and point users to vLLM plugin registration,VLLM_PLUGINS=modelexpresswhen explicit plugin selection is needed, or manualregister_modelexpress_loaders().Bugs
Validation
git diff --checkrg -n MX_REGISTER_LOADERS .returns no matchespython3 -m py_compile modelexpress_client/python/modelexpress/vllm_worker.pySummary by CodeRabbit
modelexpressis now the primary format withmxas a backward-compatible aliasMX_REGISTER_LOADERSenvironment variableMODEL_EXPRESS_URLenvironment variable documentation