Fix issue related to Mooncake Backend data corruption in CI #1114
+20
−17
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
👋 Hi magicYang1573! Thank you for contributing to ai-dynamo/nixl. Your PR reviewers will review your contribution then trigger the CI to test your changes. 🚀 |
brminich
reviewed
Dec 12, 2025
ovidiusm
reviewed
Dec 12, 2025
Contributor
|
/build |
Contributor
|
/ok to test 544596c |
Contributor
|
the test failure looks relevant |
iyastreb
reviewed
Dec 17, 2025
| mkdir build && cd build && \ | ||
| cmake .. -DBUILD_SHARED_LIBS=ON && \ | ||
| make -j2 && \ | ||
| cmake .. -DBUILD_SHARED_LIBS=ON -DUSE_CUDA=ON&& \ |
Contributor
There was a problem hiding this comment.
Suggested change
| cmake .. -DBUILD_SHARED_LIBS=ON -DUSE_CUDA=ON&& \ | |
| cmake .. -DBUILD_SHARED_LIBS=ON -DUSE_CUDA=ON && \ |
Contributor
|
@magicYang1573 Looking good to me. |
Contributor
|
@magicYang1573 casn you pls check CI issues? |
Contributor
|
/build |
Contributor
|
/ok to test 544596c |
ovidiusm
reviewed
Jan 5, 2026
| const std::string &remote_conn_info) { | ||
| std::lock_guard<std::mutex> lock(mutex_); | ||
| auto segment_id = openSegment(engine_, remote_conn_info.c_str()); | ||
| auto segment_id = openSegmentNoCache(engine_, remote_conn_info.c_str()); |
Contributor
There was a problem hiding this comment.
We need to merge this change this week if we want it to make it into NIXL 0.9.0. But there are some CI issues due to the build and test scripts changes. I suggest considering opening a PR with a minimal change that fixes the memory corruption (I suppose this line) to be able to merge faster and changing the tests separately, if possible
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
6 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What?
Fix data corruption bug in mooncake backend. Mooncake backend test in CI is passed now.
Why?
Mooncake backend cannot pass NIXL CI due to data corruption issue.
How?
When NIXL opens segment in Mooncake TransferEngine, the metadata in the last segment allocation and deallocation is not released. An additional flush is added.