Plugins/OBJ: Add support for S3 CRT Client #1127
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
👋 Hi aranadive! Thank you for contributing to ai-dynamo/nixl. Your PR reviewers will review your contribution then trigger the CI to test your changes. 🚀 |
Contributor
Author
|
/build |
aranadive
force-pushed
the
s3crtsupport
branch
from
5878674 to
ff65e32
Compare
Lets use S3 CRT Client as an additional client type when creating the object plugin. The CRT Client generally performs better for large objects by supporting multi-parting automatically and ranged GETs. This increases throughput and will help large KV transfers to objects. Both the S3Client and S3CRTClient are used based on a new backend parameter called crtMinLimit. This determines the client type used of the object size to be transfered is larger than this value, then the S3CRTClient is used. Since S3 and S3CRT are very similar API wise, most of the common code is refactored into separate files. Also, Dockerfiles are modified to compile the s3crt client as well. Signed-off-by: Adit Ranadive <aranadive@nvidia.com>
Signed-off-by: Adit Ranadive <aranadive@nvidia.com>
Signed-off-by: Adit Ranadive <aranadive@nvidia.com>
Signed-off-by: Adit Ranadive <aranadive@nvidia.com>
By default the tests use small object sizes, I modified the transfer handler to create larger objects based on parameters passed. The CRT tests will use these when testing. Signed-off-by: Adit Ranadive <aranadive@nvidia.com>
Move the common utilities for S3 and S3CRT to the utils folder. Other S3-based object plugins can link to the utils lib as required. Signed-off-by: Adit Ranadive <aranadive@nvidia.com>
Some more reorg of the object plugin to let each object storage api have its own directory. Should make it easier to onboard other S3-type plugins. Signed-off-by: Adit Ranadive <aranadive@nvidia.com>
Signed-off-by: Adit Ranadive <aranadive@nvidia.com>
Signed-off-by: Adit Ranadive <aranadive@nvidia.com>
aranadive
force-pushed
the
s3crtsupport
branch
from
780664f to
06bfddc
Compare
Contributor
Author
|
/build |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What?
This PR introduces the S3 CRT client as an additional S3 client type for the object plugin to improve performance for large object transfers by automatically using multipart uploads and ranged GET requests, which increase throughput for large KV-to-object transfers. Both S3Client and S3CRTClient are supported and selected via a new backend parameter,
crtMinLimit, so that when the object size exceeds this threshold the S3CRTClient is used. Shared logic between S3 and S3 CRT flows is refactored into common files, and the Dockerfiles are updated to compile and include the S3 CRT client in the build.Why?
The S3 CRT client is designed for high-throughput transfers and leverages multipart upload and byte-range fetches automatically, which yields better performance and reliability for large objects compared with the standard S3 client. Using it only above a configurable size threshold via
crtMinLimitallows the system to gain these benefits for large transfers while keeping behavior unchanged for smaller objects and minimizing unnecessary resource usage.How?
crtMinLimitas a backend configuration parameter to determine when to route operations to S3CRTClient instead of S3Client based on object size.crtMinLimit, taking advantage of automatic multipart uploads and ranged GETs for improved throughput.