Default marketplace name to a rename-me placeholder + document renaming - #11
Merged
Merged
Conversation
The template shipped marketplace.name = "ai-plugin-marketplace" (and owner "AI
Plugin Marketplace Template") — the upstream's own name. Forking via "Use this
template" copies it verbatim, and nothing nudged you to change it, so forks
collided with the upstream marketplace name (the second one installed strands
the first's plugins).
- aipm.workspace.ts: name -> "my-ai-plugins", owner -> "Your Name", with a
prominent RENAME-THIS comment and the "<handle>-ai-plugins" convention.
- README: an IMPORTANT callout to rename the marketplace before publishing.
- CONTRIBUTING: a step-0 "rename the marketplace" instruction.
- Regenerated registries reflect the new placeholder name.
Pairs with toolkit changes (separate PR in ai-plugin-marketplace/tools): an
`aipm validate` warning while the name is still a default, and `aipm init
--name` defaulting to "${USER}-ai-plugins".
There was a problem hiding this comment.
Pull request overview
Updates the template’s default marketplace identity to a non-upstream placeholder and adds prominent documentation instructing downstream forks to rename before publishing, reducing the risk of marketplace-name collisions that can strand/shadow plugins.
Changes:
- Default
marketplace.name/ownerinaipm.workspace.tsto placeholders and add a prominent rename warning comment. - Add “rename your marketplace” guidance to README and CONTRIBUTING.
- Regenerate committed marketplace registries for Cursor and Claude to reflect the placeholder values.
Reviewed changes
Copilot reviewed 5 out of 5 changed files in this pull request and generated 4 comments.
Show a summary per file
| File | Description |
|---|---|
| README.md | Adds an IMPORTANT callout instructing users to rename the marketplace before publishing. |
| CONTRIBUTING.md | Adds a step-0 instruction to rename the marketplace immediately after forking. |
| aipm.workspace.ts | Switches marketplace defaults to placeholders and documents the renaming requirement in-code. |
| .cursor-plugin/marketplace.json | Updates generated marketplace registry name/owner to placeholder values. |
| .claude-plugin/marketplace.json | Updates generated marketplace registry name/owner to placeholder values. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Comment on lines
+22
to
+23
| marketplace (e.g. the upstream `ai-plugin-marketplace`), which strands plugins. `aipm | ||
| validate` emits a warning until you change it. |
| ## Workflow | ||
|
|
||
| 0. **One-time, right after forking: rename the marketplace.** In `aipm.workspace.ts`, | ||
| set `marketplace.name` (and `owner`) from the placeholder `my-ai-plugins` to a |
|
|
||
| > [!IMPORTANT] | ||
| > **Rename your marketplace first.** Open `aipm.workspace.ts` and change | ||
| > `marketplace.name` (and `owner`) from the placeholder `my-ai-plugins` to a |
Comment on lines
+28
to
+31
| > [!IMPORTANT] | ||
| > **Rename your marketplace first.** Open `aipm.workspace.ts` and change | ||
| > `marketplace.name` (and `owner`) from the placeholder `my-ai-plugins` to a | ||
| > **unique** name — convention `"<your-handle>-ai-plugins"`, e.g. `mnorth-ai-plugins`. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
The template shipped
aipm.workspace.tswithmarketplace.name = "ai-plugin-marketplace"andowner = "AI Plugin Marketplace Template"— the upstream's own name. Forking via "Use this template" copies it verbatim, and nothing prompted a rename, so forks register their marketplace under the same name as the upstreamai-plugin-marketplace. When two marketplaces share a name, the second one installed shadows/strands the first's plugins. (This bit a real downstream marketplace.)Change
aipm.workspace.ts:name → "my-ai-plugins",owner → "Your Name", with a prominentRENAME THIScomment and the"<handle>-ai-plugins"convention.> [!IMPORTANT]callout to rename the marketplace before publishing.aipm build) reflect the placeholder name;aipm build+aipm validateare clean.Companion (separate PR,
ai-plugin-marketplace/tools)The toolkit side makes this robust beyond docs:
aipm validatewarns whilemarketplace.nameis still a default placeholder.aipm init --name <name>(defaulting to${USER}-ai-plugins) sets a distinct name up front.