Skip to content

Reconcile bundler README/LICENSE placement with template repo's root-level convention (template d2d9923+) #89

Description

@mike-north

Problem

The ai-plugin-marketplace/template repo intentionally moved README.md/LICENSE from per-plugin source (plugins/<plugin>/README.md) to the repo root at commit d2d9923. The tools bundler (gemini/kiro targets) still emits and asserts per-plugin README.md/LICENSE copies, so the tools output and the template's current structure have diverged. This is why #86 had to pin the CI parity oracle at 80f2b87 — the last template revision before d2d9923 — rather than at template main HEAD. Until the bundler is reconciled with the root-level convention, the pin cannot advance and the parity suites can never track the current template.

Dependency

Builds on #86 (merged): the pin file .github/template-repo.rev and the CI second-checkout wiring must exist first. This issue advances that pin to template HEAD as its end-to-end proof.

Governing references

  • Template repo ai-plugin-marketplace/template at d2d9923 (the README/LICENSE root-move) and its current main HEAD (the target the pin should reach).
  • GeneratedFile.target shared-artifact ownership model, shipped in Model shared-artifact ownership in GeneratedFile.target #54 (commit 600e3a0, "Model shared-artifact ownership in GeneratedFile.target") — the reconciliation MUST build on this model (root-level README/LICENSE are shared artifacts, not per-plugin ones); do not invent a parallel ownership mechanism.
  • packages/core/src/targets/gemini/bundle.ts + packages/core/src/targets/kiro/bundle.ts (the emitters) and their bundle.test.ts parity suites (the assertions that currently expect per-plugin README/LICENSE).
  • docs/specs/adapter-system.md / architecture.md sections covering emitted-file ownership, and docs/specs/lint-engine.md if bundle emission is described there.
  • Run the gemini/kiro bundle parity suites in CI against a pinned template revision, eliminating the CI-skips-entirely asymmetry #86's pin file .github/template-repo.rev and CI wiring.

Acceptance criteria

  1. The bundler correctly handles the template's root-level README.md/LICENSE convention (template d2d9923+), modeled through GeneratedFile.target shared-artifact ownership rather than per-plugin copies — i.e. the emitted output matches what the current template produces.
  2. The gemini and kiro bundle parity suites pass against template HEAD (not the old pinned rev) — the structural divergence is gone.
  3. The pin in .github/template-repo.rev is bumped to template main HEAD in this same PR, and the PR's own CI (which runs the parity suites against the pinned rev, per Run the gemini/kiro bundle parity suites in CI against a pinned template revision, eliminating the CI-skips-entirely asymmetry #86) is green — this proves the bump procedure works end-to-end.
  4. Any spec text describing bundle emission / emitted-file ownership is updated to reflect the root-level shared-artifact model.

Non-goals

Escalation

Priority normal; no product decision needed from Mike UNLESS the implementer finds the two conventions (per-plugin vs root-level README/LICENSE) genuinely incompatible — e.g. some target legitimately needs per-plugin copies while another needs root-level. In that case STOP and escalate through the PM rather than forcing an alignment.

Proof

  • Parity suites run and pass in CI against the bumped pin (= template HEAD) on this PR — visible in the CI job log (describe blocks execute, not skip), demonstrating both the reconciliation (AC 1–2) and the pin bump (AC 3).
  • pnpm run check green locally with a template-HEAD checkout via AIPM_TEMPLATE_REPO.

Activity

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

No one assigned

    Labels

    bugSomething isn't workingin progressClaimed by a fleet implementer

    Type

    No type

    Projects

    No projects

      Milestone

      No milestone

      Relationships

      None yet

      Development

      No branches or pull requests

      Issue actions